feat(core): declare versioned browser protocol capabilities - #106
Merged
seonghobae merged 20 commits intoAug 26, 2026
Merged
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This was referenced Aug 12, 2026
seonghobae
marked this pull request as ready for review
August 26, 2026 22:14
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Partial implementation of #28 and Proposed ADR 0107, stacked on canonical browser-authority owner PR #40.
Buyer/foundation boundary
OriginWeave needs an explicit version/capability descriptor before WebDriver BiDi and pinned CDP adapters can coexist safely.
BrowserProtocolAdapterDescriptorrecords explicit protocol kind, bounded adapter/upstream-protocol/browser revision tokens, and a non-empty duplicate-free capability set in deterministic canonical order. Protocol family grants no capability by itself and this metadata grants no browser/action/network/secret authority.Fresh dependency state
Protected
mainis exactb05d5acca82b9d916ada2c8e82f59f92a89817e1. Canonical prerequisite #40 is exact93ce1e7efad0a1e8c107f1f465a5260ba568d466. Current #106 head is exact378a9f2613f4044ece20246bab6cd77f35018981.Fresh comparison from exact #40 to this head is 20 commits ahead / 0 behind, with merge base exactly
93ce1e7efad0a1e8c107f1f465a5260ba568d466. The semantic delta is the intended protocol descriptor plus the required current-crate-root export adaptation:CHANGELOG.md,crates/originweave-core/src/browser_protocol.rs,crates/originweave-core/src/lib.rs,crates/originweave-core/src/root.rs, andcrates/originweave-core/tests/browser_protocol_adapter.rs. GitHub reports the PR open, Draft, and mergeable. Keep Draft while #40 remains active.Reconstruction / repair lineage
The predecessor child had diverged from moved #40. This run non-destructively reconstructed the descriptor on the exact live #40 tree at merge commit
56e7b5e1f9000f27022dfc7f4a01d6d928cb399b, restored the child changelog at4943b824877a44068a22d3ef17ce1de66b926173, then used exact-head CI as a real adaptation test. CI32790736295exposed that the current crate root issrc/root.rs, so editing onlysrc/lib.rsleft the public descriptor unavailable to external tests. Exact head01fd68fe1f8faa8725558fb2a8ed61e67602e10brepaired the crate-root export; its next CI reached only canonical rustfmt drift. Current head378a9f2613f4044ece20246bab6cd77f35018981applies that canonical formatting. No force-push or destructive rebase was used.Historical test-only heads
c0da8bd7537c0b242d9f6e6d38dce8ff42417032and8d2549cbad8cdabfe09a5ee61aa7a7ee1de81cc8remain regression lineage only: they established the missing descriptor boundary and caller-order-dependent capability identity respectively.Exact-current GREEN evidence
On unchanged exact head
378a9f2613f4044ece20246bab6cd77f35018981:32791314299: success;97633270488: exact-head checkout, Python repository contracts, canonical formatting, locked workspace/all-target check, full tests, strict Clippy, and rustdoc success;97633270287: exact-head checkout and owned production functions, lines, regions, and branches all exactly 100% covered;9543254652,exact-coverage-378a9f2613f4044ece20246bab6cd77f35018981, ZIP SHA-2561370c6f27e2421303c709be02621b2880840ef54d30f1cd23157e46b8cba23eb;32791314189: success;This exact feature-base head exposes CI and Manifest V3 workflows only; no SAST or Security Scan result is claimed. No prerequisite/predecessor/synthetic/skipped/cancelled/pending/status-only/model-only evidence is promoted as current proof.
Authority / truth boundary
This descriptor does not speak BiDi/CDP, authenticate an adapter, mint session/context/node authority, execute input, authorize destination/network/TLS/HTTP, expose arbitrary JavaScript, or establish BiDi/CDP semantic parity. #40's authority-registry and extension/task constraints are inherited prerequisite semantics, not unique #106 work.
There is no qualifying independent current-head approval. Protected-main
AGENTS.mdremains authoritative; this scheduled writer does not merge, self-approve, alter workflows/rulesets/secrets, force-push, tag, release, or publish.