feat(reports): leftover-map comparison graphic leftover-map axis origin ticks independently of leftover-map axis share and leftover-map singular values (v2.101.0) - #886
Conversation
…in ticks independently of leftover-map axis share and leftover-map singular values (v2.101.0)
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Exact head |
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
| ): LeftoverMapCompareAxisBadge { | ||
| const singular = formatLeftoverMapPlotAxisSingular(leftoverSingular); | ||
| const percent = formatLeftoverMapPlotAxisShare(leftoverShare); | ||
| const origin = leftoverMapPlotTickIsOrigin(tickLabel); |
There was a problem hiding this comment.
📝 Info: Origin detection shares its formatter
leftoverMapPlotTickIsOrigin and coordinate tick generation use formatSignedLeftoverValue. Generated zero labels therefore match without a separate numeric-origin source.
Was this helpful? React with 👍 or 👎 to provide feedback.
| const origin = leftoverMapPlotTickIsOrigin(tickLabel); | ||
| if (singular === null && percent === null) { | ||
| return { key: LEFTOVER_MAP_COMPARE_PLOT_TICK, values: { axis: axisIndex, value: tickLabel } }; | ||
| return { | ||
| key: origin ? LEFTOVER_MAP_COMPARE_PLOT_ORIGIN_TICK : LEFTOVER_MAP_COMPARE_PLOT_TICK, | ||
| values: { axis: axisIndex, value: tickLabel }, | ||
| }; | ||
| } | ||
| if (singular === null && percent !== null) { | ||
| return { | ||
| key: LEFTOVER_MAP_COMPARE_PLOT_TICK_SHARE, | ||
| key: origin ? LEFTOVER_MAP_COMPARE_PLOT_ORIGIN_TICK_SHARE : LEFTOVER_MAP_COMPARE_PLOT_TICK_SHARE, | ||
| values: { axis: axisIndex, value: tickLabel, share: percent }, | ||
| }; | ||
| } | ||
| if (singular !== null && percent === null) { | ||
| return { | ||
| key: LEFTOVER_MAP_COMPARE_PLOT_TICK_SINGULAR, | ||
| key: origin | ||
| ? LEFTOVER_MAP_COMPARE_PLOT_ORIGIN_TICK_SINGULAR | ||
| : LEFTOVER_MAP_COMPARE_PLOT_TICK_SINGULAR, | ||
| values: { axis: axisIndex, value: tickLabel, singular }, | ||
| }; | ||
| } | ||
| return { | ||
| key: LEFTOVER_MAP_COMPARE_PLOT_TICK_SINGULAR_SHARE, | ||
| key: origin | ||
| ? LEFTOVER_MAP_COMPARE_PLOT_ORIGIN_TICK_SINGULAR_SHARE | ||
| : LEFTOVER_MAP_COMPARE_PLOT_TICK_SINGULAR_SHARE, |
There was a problem hiding this comment.
📝 Info: Badge omissions remain independent
Origin selection only changes the translation key. Existing singular and share validation still controls each optional value independently.
Was this helpful? React with 👍 or 👎 to provide feedback.
|
Stacked #887 @ |
|
Cycle write probe 2026-08-31T11:00Z: independent APPROVE still required on exact head |
1 participant
Summary
Stacked on #885 @
7a6c038(feat/leftover-map-plot-tick-origin-badge-v21000). leftoverMapComparePlotTickAxisBadge (ADR 0344 / v2.101.0) names leftover-map comparison graphic leftover-map axis origin ticks independently of leftover-map axis share and leftover-map singular values.leftover map comparison graphic leftover-map axis {axis} origin tick {value}when leftoverMapPlotTickIsOrigin returns true (formatSignedLeftoverValue(0)===0.00).0.00.leftover map comparison graphic leftover-map axis {axis} origin tick {value} σ {singular},leftover map comparison graphic leftover-map axis {axis} origin tick {value} {share}%, andleftover map comparison graphic leftover-map axis {axis} origin tick {value} σ {singular} {share}%.leftover map comparison graphic leftover-map axis {axis} tick {value}.σ_k.Test plan
pnpm exec oxlinton leftover-map plot tick files: 0 warnings, 0 errorspnpm exec tsc -bcleanLeave open for independent review. Do not self-approve. Do not squash-merge.