feat(reports): leftover-map item coordinates on leftover-map comparison leftover pair leftover-map criterion independently of leftover-map comparison leftover pair leftover-map post leftover-map person coordinates (v2.99.0) - #884
Conversation
…on leftover pair leftover-map criterion independently of leftover-map comparison leftover pair leftover-map post leftover-map person coordinates (v2.99.0) leftoverMapCompareListCriterionBadge (ADR 0342) names leftover-map comparison leftover-pair leftover-map criterion leftover-map item coordinates independently of leftover-map comparison leftover-pair leftover-map post leftover-map person coordinates. Rank-0 unused axes still name ζ (0.00, 0.00). Do not invent leftover-map item coordinates from ξ. UI-only. No SQL. Never invent a leftover score or a theta.
|
@coderabbitai review Write probe 2026-08-31T09:53Z. Independent review requested on exact head |
|
Warning Review limit reachedNext included review available in 46 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (22)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
|
|
Queue note (do not self-approve; do not wait on Checks).
Next buyer gap on this head (not #877): leftover-map graphic leftover-map axis origin ticks independently of leftover-map axis share and leftover-map singular values as leftoverMapPlotTickAxisBadge (ADR 0343 / v2.100.0). Distinct accessible name leftover-map axis {k} origin tick {value}. Rank-0 unused axes still name leftover-map origin 0.00. Share and singular omit independently. Do not invent leftover-map origin from leftover-map axis share or σ_k. leftoverMapComparePlotTickAxisBadge stays on #877. UI-only, no SQL, no new columns. Never invent a leftover score or a theta. |
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
| {listCriterionBadge ? ( | ||
| <span | ||
| className="post-badge" | ||
| aria-label={tf(listCriterionBadge.key, listCriterionBadge.values)} | ||
| > | ||
| {tf(listCriterionBadge.key, listCriterionBadge.values)} | ||
| </span> | ||
| ) : null} |
There was a problem hiding this comment.
🟡 Criterion coordinates remain inaccessible
With finite item coordinates, listCriterionBadge sits inside a separately labeled button. Assistive technology exposes only the post label, hiding the criterion coordinates.
Prompt for agents
The comparison pair button in frontend/src/App.tsx has its own aria-label for the post coordinates, while the new criterion-coordinate span is nested inside that button. An explicit button label replaces descendant text in the button's accessible name, and button descendants are flattened in accessibility APIs, so the span's aria-label does not provide the distinct accessible caption required by ADR 0342. Restructure the markup so both the post button and criterion-coordinate caption remain separately exposed to assistive technology without changing the click behavior or coupling ζ visibility to ξ. Add an accessibility assertion that inspects the exposed role/name structure rather than only locating the span by aria-label in the DOM.
Was this helpful? React with 👍 or 👎 to provide feedback.
|
Stacked successor opened: #885 leftover-map graphic leftover-map axis origin ticks independently of leftover-map axis share and leftover-map singular values as leftoverMapPlotTickAxisBadge (ADR 0343 / v2.100.0) @ |
1 participant
Summary
Stacked on #883 @
bdd48e2(feat/leftover-map-compare-list-post-coordinates-v2980). leftoverMapCompareListCriterionBadge (ADR 0342 / v2.99.0) names leftover-map comparison leftover-pair leftover-map criterion leftover-map item coordinates independently of leftover-map comparison leftover-pair leftover-map post leftover-map person coordinates.leftover map comparison leftover pair leftover-map criterion {label} at ζ {item}when leftover-map item coordinates are finite.ξ.ζstill names when leftover-map comparison leftover-pair leftover-map post leftover-map person coordinatesξare missing (formatLeftoverMapCoordinatesstill requires both).(0.00, 0.00).leftover map comparison leftover pair leftover-map post {title} at ξ {person}.leftover pair leftover-map criterion {label} at ζ {item}.leftover-map criterion {label} at ζ {item}.leftover map comparison graphic leftover-map criterion {label} at ζ {item}.ξ. Do not invent leftover-map person coordinatesξfrom leftover-map item coordinatesζ.Test plan
pnpm exec oxlinton leftover-map pair-list files: 0 warnings, 0 errorspnpm exec tsc -bcleanLeave open for independent review. Do not self-approve. Do not squash-merge.