Skip to content

fix(runtime): retain partial readiness evidence #790

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
seonghobae merged 1 commit into from
Aug 28, 2026
Merged

fix(runtime): retain partial readiness evidence #790

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions docker-compose.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,8 +106,8 @@ services:
context: ./docker/contextual-orchestrator
dockerfile: Dockerfile
args:
CONTEXTUAL_ORCHESTRATOR_SOURCE_REVISION: 2712827bfebd8be39e25c24924ad1f18522fd5f9
image: ${COMPOSE_PROJECT_NAME:-lineageweave}-orchestrator:2712827bfebd8be39e25c24924ad1f18522fd5f9
CONTEXTUAL_ORCHESTRATOR_SOURCE_REVISION: 3558a9a3aeb985282b255fcd80bb2201c19ae54b
image: ${COMPOSE_PROJECT_NAME:-lineageweave}-orchestrator:3558a9a3aeb985282b255fcd80bb2201c19ae54b
env_file:
- ${HOME}/.env
environment:
Expand Down
2 changes: 1 addition & 1 deletion docker/contextual-orchestrator/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
ARG MATURIN_BUILDER_IMAGE=ghcr.io/pyo3/maturin@sha256:b6c8b59a0170b77eb31a35b56034abd39972483ad0ebfff344deaa42a85f3bd3
FROM ${MATURIN_BUILDER_IMAGE} AS token-builder

ADD --checksum=sha256:0220f0cff25446c38260cb4cd10be5de7d4b5dca5b36ae5dd0b7eb49cef625fd https://github.com/ContextualWisdomLab/contextual-orchestrator/archive/2712827bfebd8be39e25c24924ad1f18522fd5f9.tar.gz /tmp/contextual-orchestrator.tar.gz
ADD --checksum=sha256:8dcd15b023aa1205a091d7826e278713d43bc1981dbd6a7189a7382e7f69cad3 https://github.com/ContextualWisdomLab/contextual-orchestrator/archive/3558a9a3aeb985282b255fcd80bb2201c19ae54b.tar.gz /tmp/contextual-orchestrator.tar.gz

@devin-ai-integration devin-ai-integration Bot Aug 28, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔍 Archive checksum unverifiable in-repo

The ADD --checksum sha256 was updated to 8dcd15b0... for the new pinned commit. This is the one value the PR cannot self-verify; if it does not match the real archive bytes the build fails closed at fetch time.

Devin Review

Was this helpful? React with 👍 or 👎 to provide feedback.

RUN mkdir -p /build/contextual-orchestrator \
&& tar -xzf /tmp/contextual-orchestrator.tar.gz --strip-components=1 \
-C /build/contextual-orchestrator \
Expand Down
4 changes: 3 additions & 1 deletion docs/adr/0083-orchestrator-runtime-commit-pin.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ multi-agent.
## Decision

`docker/contextual-orchestrator/Dockerfile` pins the downloaded archive to
commit `2712827bfebd8be39e25c24924ad1f18522fd5f9` from upstream PR #857.
commit `3558a9a3aeb985282b255fcd80bb2201c19ae54b` from upstream PR #857.
The candidate pin supplies exact `Retry-After` admission deferral,
rate-budget-derived readiness polling cadence, and endpoint-scoped structured
admission. Readiness now measures both the internal JSON-Schema judge and the
Expand Down Expand Up @@ -60,6 +60,8 @@ The runtime contract is:
- Asynchronous provider-readiness jobs declare the positive integer polling
cadence derived from the server's configured admission window; consumers do
not invent a polling interval.
- One candidate's bounded probe failure records that candidate as not ready;
it does not discard successful readiness evidence from other candidates.

## Consequences

Expand Down
2 changes: 1 addition & 1 deletion docs/product-technical-gap-baseline.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
> exact-head evidence before this overlay is
> `760d05896f96e5ce7fb9df0e4b62369448913fbd` and remains candidate-only.
> Its contextual-orchestrator runtime is pinned to open upstream PR #857 exact
> `2712827bfebd8be39e25c24924ad1f18522fd5f9`; this candidate is not
> `3558a9a3aeb985282b255fcd80bb2201c19ae54b`; this candidate is not
> protected-main evidence.
> The open queue has 14 PRs:
> #783, #782, #781, #780, #778, #774, #772, #771, #770, #702, #679, #672,
Expand Down
2 changes: 1 addition & 1 deletion tests/test_documentation_hygiene.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,7 @@ def test_role_catalog_identity_migration_is_wired() -> None:

def test_orchestrator_runtime_pin_matches_adr() -> None:
"""The image pin and ADR must describe the same immutable upstream commit."""
expected_embedding_contract_commit = "2712827bfebd8be39e25c24924ad1f18522fd5f9"
expected_embedding_contract_commit = "3558a9a3aeb985282b255fcd80bb2201c19ae54b"
dockerfile = (
_ROOT / "docker" / "contextual-orchestrator" / "Dockerfile"
).read_text(encoding="utf-8")
Expand Down
2 changes: 1 addition & 1 deletion tests/test_runtime_image_revision_contract.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ def test_compose_passes_revision_to_all_product_images() -> None:
) == 4
assert (
"CONTEXTUAL_ORCHESTRATOR_SOURCE_REVISION: "
"2712827bfebd8be39e25c24924ad1f18522fd5f9"
"3558a9a3aeb985282b255fcd80bb2201c19ae54b"
) in compose


Expand Down
Loading