-
Notifications
You must be signed in to change notification settings - Fork 1
feat(ontology): select represented occupations #746
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
seonghobae
merged 12 commits into
feat/onet-rating-source-catalog
from
feat/onet-occupation-selector
Aug 27, 2026
Merged
Changes from 11 commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
37a63cc
feat(ontology): select represented occupations
seonghobae e76d182
Merge branch 'feat/onet-rating-source-catalog' into feat/onet-occupat…
seonghobae ff4d176
fix(ui): invalidate rating requests on source change
seonghobae e31f528
Merge remote-tracking branch 'origin/feat/onet-rating-source-catalog'…
seonghobae 0f3017a
fix(ui): clear evidence when occupation changes
seonghobae 579be9c
fix(ui): distinguish unavailable occupation catalogs
seonghobae ec8be16
Merge remote-tracking branch 'origin/feat/onet-rating-source-catalog'…
seonghobae 4983b29
fix(ui): align empty evidence guidance with selector
seonghobae 616b9da
fix(ui): distinguish unavailable occupation catalogs
fe78ee6
Merge branch 'feat/onet-rating-source-catalog' of https://github.com/…
ee380cf
Merge branch 'feat/onet-rating-source-catalog' into feat/onet-occupat…
seonghobae 17e8774
Merge branch 'feat/onet-rating-source-catalog' into feat/onet-occupat…
seonghobae File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,45 @@ | ||
| # ADR 0261: Occupations represented by an imported rating source | ||
|
|
||
| - Status: Accepted | ||
| - Date: 2026-08-27 | ||
| - Extends: ADR 0257, ADR 0258, ADR 0260 | ||
|
|
||
| ## Context | ||
|
|
||
| The source catalog removes internal release/source entry, but ADR 0260 still | ||
| leaves users to type an O*NET-SOC code. The normalized store already preserves | ||
| the source occupation title and code. A release may contain occupations that | ||
| are absent from one rating artifact, so the release classification alone is | ||
| not sufficient evidence that a profile exists for the selected source. | ||
|
|
||
| ## Decision | ||
|
|
||
| 1. Add an authenticated read endpoint returning stored O*NET-SOC code/title | ||
| pairs that have at least one observation in one exact imported rating | ||
| source. Keep unavailable source distinct from an available empty source. | ||
| 2. Join by normalized release/code identity and an observation-existence | ||
| predicate. Do not bind occupations by title similarity, keyword inference, | ||
| external search, or a locally reconstructed classification. | ||
| 3. Order by the stored occupation title and then code. Return the complete | ||
| represented set because the official imported classification is the | ||
| authoritative finite selector domain; do not introduce an arbitrary result | ||
| cutoff that makes valid occupations disappear. | ||
| 4. Replace free-text occupation-code entry with a native select whose visible | ||
| label begins with the stored title and retains the exact code. Changing the | ||
| rating source clears both occupation selection and displayed evidence; | ||
| changing the occupation clears displayed evidence. | ||
| 5. While the occupation catalog is loading, empty, or unavailable, disable | ||
| profile submission and state the next action. Pagination remains bound to | ||
| the identifiers returned by the loaded profile under ADR 0259. | ||
|
|
||
| ## Consequences | ||
|
|
||
| Users choose an occupation by its authoritative title without knowing an | ||
| internal code, while API requests continue to carry exact stable identifiers. | ||
| Employer job families and series remain outside this selector until their | ||
| separate authorized import contract exists. | ||
|
|
||
| ## References | ||
|
|
||
| National Center for O*NET Development. (2026). *O*NET 31.0 database* [Data | ||
| set]. https://www.onetcenter.org/database.html |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.