-
Notifications
You must be signed in to change notification settings - Fork 1
fix(backend): restore runtime and integration contracts #660
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
1f1bc3e
fix(backend): restore runtime and integration contracts
29d66f6
fix(tests): adopt Starlette supported transport
6eca4ac
fix(tests): keep httpx2 in the existing dev extra
a4f4c87
fix(backend): require the FastAPI status API in use
7d0d3ef
docs: align integration transport contract
be3e28c
feat(semantic): persist explicit content unit kinds (#664)
seonghobae c10cae0
docs(gaps): record stacked full-suite evidence
24fda08
docs(gaps): record semantic stack merge
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| ### Fixed | ||
|
|
||
| - Restored the runtime-only TEPP credential setting, kept API integration fixtures collision-free, aligned asynchronous Ask tests with semantic retrieval, replaced deprecated FastAPI 422 constants, and moved Starlette integration tests to its supported `httpx2` transport. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,43 @@ | ||
| # ADR 0223: Explicit semantic content unit kinds | ||
|
|
||
| **Status:** Accepted | ||
| **Date:** 2026-08-26 | ||
|
|
||
| ## Context | ||
|
|
||
| PRD-FR-4 requires ordered paragraph, list, table, formula, | ||
| conversation-turn, and image-region semantic units. The source parser already | ||
| kept those boundaries, but `post_content_unit.unit_kind_code` collapsed every | ||
| textual DOM unit to `dom` and every markup-free unit to `plain_text`. A stored | ||
| row therefore could not disclose which source boundary produced its embedding. | ||
|
|
||
| ## Decision | ||
|
|
||
| 1. PostgreSQL admits `paragraph`, `list`, `table`, `formula`, and | ||
| `conversation_turn` as governed `post_content_unit_kind` values. Existing | ||
| `plain_text`, `dom`, and `image` values remain valid historical values. | ||
| 2. New writes classify only explicit source boundaries: paragraph/plain-text | ||
| chunks, `li`, table rows, top-level MathML `math`, and caller-parsed | ||
| conversation turns. Unknown DOM blocks remain `dom`; no prose pattern or | ||
| model guess manufactures a kind. | ||
| 3. MathML is retained as one ordered formula boundary. This decision does not | ||
| parse, evaluate, or assign mathematical meaning to the expression. | ||
| 4. Image regions remain normalized children of their document-order image | ||
| unit under ADR 0091 rather than duplicating them as top-level content units. | ||
| 5. A source adapter may pass already parsed `Chunk` units to persistence. | ||
| LineageWeave does not infer RFC 5322 sender boundaries from an opaque body. | ||
|
|
||
| ## Consequences | ||
|
|
||
| - Embedding rows remain attached to the same ordered source unit while their | ||
| stored kind becomes inspectable and stable. | ||
| - Existing rows are not rewritten, so provenance is preserved. | ||
| - Formula evaluation and formula ontology remain outside LineageWeave. | ||
|
|
||
| ## References | ||
|
|
||
| World Wide Web Consortium. (2025). *MathML Core* (Candidate Recommendation | ||
| Snapshot, June 24, 2025). https://www.w3.org/TR/2025/CR-mathml-core-20250624/ | ||
|
|
||
| Resnick, P. W. (Ed.). (2008). *Internet message format* (RFC 5322). Internet | ||
| Engineering Task Force. https://www.rfc-editor.org/rfc/rfc5322 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.