-
Notifications
You must be signed in to change notification settings - Fork 1
fix(ci): keep lineage SQL static at call sites #647
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
d991bfb
0c08da4
97f2088
471da7b
17273cf
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -300,7 +300,7 @@ async def lifespan(app: FastAPI): | |||||
| timeout=load_settings().orchestrator_answer_timeout_seconds | ||||||
| ), | ||||||
| embedding_factory=_embedding_client, | ||||||
| claim_verification_factory=lambda: _claim_verification_client(), | ||||||
| claim_verification_factory=_claim_verification_client, | ||||||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🔴 Claim-verification factory loses late binding Passing
Suggested change
Was this helpful? React with 👍 or 👎 to provide feedback. |
||||||
| ) | ||||||
| ) | ||||||
| app.state.global_ask_worker = global_ask_worker | ||||||
|
|
||||||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
📝 Info: SQL extraction preserves the original queries
The new
_RECONSTRUCTION_SOURCE_SQLand_VISIBLE_LINEAGE_SOURCE_SQLreproduce the removed inline queries.SOURCE_POST_ELIGIBILITY_SQL.format(alias="source_post")resolves{alias}to a brace-free string, so the outer.format(eligibility=...)cannot re-interpret braces. Column lists match exactly.Was this helpful? React with 👍 or 👎 to provide feedback.