fix: validate ontology shape term kinds - #618
Merged
Merged
Conversation
…R 0205) Resolves #372. Supersedes ADR 0157: the repository-case public namespace https://contextualwisdomlab.github.io/LineageWeave/ontology# is the exact project path GitHub Pages serves and becomes the only spelling new runtime values, exports, fixtures, and database rows mint. The lowercase form stays published as a deprecated compatibility vocabulary with validated equivalentClass/equivalentProperty mappings, and scripts/migrate_legacy_namespace.py rewrites stored lowercase IRIs (dry-run by default; never touches provenance columns). Also lands the completeness increments that motivated the decision: grounded node-attribute datatype properties, the SKOS post-type scheme, person-side disjointness plus inverse affiliation, and a closed-world SHACL shapes graph (docs/ontology/lineageweave-kg-shapes.ttl) validated against every DB-to-RDF projection and published beside the ontology. Full unit suite: 1095 passed, 12 skipped.
…ory-case-namespace # Conflicts: # CHANGELOG.md # pyproject.toml
…as role=status Its resolved empty/unavailable state carried role="status" like sibling panels' transient loading text does, so mounting it inside the Board's collapsed Advanced Review Tools details collided with every other status region on the page (4 failing App.test.tsx assertions). RankingsPanel's own resolved placeholders carry no ARIA role for the same reason -- only the "Loading..." state announces.
|
Warning Review limit reachedNext included review available in 20 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (3)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
# Conflicts: # frontend/src/App.test.tsx # scripts/publish_ontology_site.py # tests/test_publish_ontology_site.py
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
seonghobae
enabled auto-merge (squash)
August 25, 2026 11:40
This was referenced Aug 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verification
uv run --extra dev pytest -q tests/test_publish_ontology_site.py tests/test_ontology.py(34 passed)cd frontend && corepack pnpm exec vitest run src/App.test.tsx -t "opens related nodes from a related corporate entity" --testTimeout=15000(1 passed, 92 skipped)Follow-up to review findings that arrived on #616 immediately before it merged.