fix(ui): stop WorkspaceCalendar's fail-closed placeholder announcing as role=status - #615
Merged
Merged
Conversation
…as role=status Its resolved empty/unavailable state carried role="status" like sibling panels' transient loading text does, so mounting it inside the Board's collapsed Advanced Review Tools details collided with every other status region on the page (4 failing App.test.tsx assertions). RankingsPanel's own resolved placeholders carry no ARIA role for the same reason -- only the "Loading..." state announces.
|
Warning Review limit reachedNext included review available in 12 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
seonghobae
enabled auto-merge
August 25, 2026 09:42
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
WorkspaceCalendar's resolved empty/fail-closed "Observed calendar events" placeholder carriedrole="status"like sibling panels' transient loading text does, not their resolved placeholders (RankingsPanel's own empty/unavailable states carry no ARIA role for exactly this reason).WorkspaceCalendarmounts inside the Board's collapsed "Advanced review tools"<details>viaCalendarPanel, this collided with every otherrole="status"region on the page whenever the calendar fixture resolves to zero events -- 4 currently-failingApp.test.tsxassertions on protectedmainright now (TestingLibraryElementError: Found multiple elements with the role "status").Root cause
Confirmed live on
origin/maintip (3f473480) directly, unrelated to any in-flight PR -- reproduced by runningpnpm exec vitest run src/App.test.tsxagainst a clean main checkout before making any change.Fix
Removed
role="status"from the one placeholder<p>(frontend/src/components/WorkspaceCalendar.tsx), matching the established convention elsewhere in this file: only the "Loading..." state announces; a settled empty/unavailable placeholder does not.Test plan
pnpm run lint-- cleanpnpm run build-- cleanpnpm exec vitest run src/App.test.tsx src/components/WorkspaceCalendar.test.tsx-- 95/95 passed (was 4 failing before the fix)pnpm exec vitest run(full suite) -- 356/356 passed