feat(ask): bind relative-time filters to event time (v2.13.0) - #581
Conversation
Global Ask 어제/그저께/지난주 now compares coalesce(event_occurred_at, created_at) on the Seoul calendar. Clustered bulk imports keep yesterday's events retrievable. Cited evidence names Time axis so a click still opens that post (ADR 0168).
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
Cycle note 2026-08-24T12:24Z. Head Independent APPROVE is required. I will not self-approve or squash-merge this PR. Squash-merge only with an independent APPROVE on this exact head plus required checks success. Copilot review requested. seonghobae is currently the only collaborator, so a human independent APPROVE still has to come from outside this loop. |
|
Warning Review limit reachedNext included review available in 15 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (26)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
seonghobae
left a comment
seonghobae
left a comment
There was a problem hiding this comment.
Copilot/human independent review requested. Do not treat this comment as APPROVE.
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
…ilter-v2130 # Conflicts: # CHANGELOG.md # CLAUDE.md # frontend/package.json # pyproject.toml # uv.lock
The post-merge seeded_db fixture created source_post rows with event_occurred_at (scripts/seed_demo_data.py::insert_fixture_source_posts) but never applied migrations/0168_source_post_event_occurred_at.sql, so six backend/tests/test_api.py tests failed with UndefinedColumn. Wire the migration in alongside the other seeded_db migrations.
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
…ilter-v2130 # Conflicts: # CHANGELOG.md # backend/app/post_chat_ingestion.py # backend/tests/test_api.py # frontend/package.json # pyproject.toml # uv.lock
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
…ilter-v2130 # Conflicts: # backend/tests/test_api.py # frontend/package.json # pyproject.toml # uv.lock
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
# Conflicts: # CHANGELOG.md
Main's 0183 slot is taken by the GNB four-Korean-chrome ADR (#587), so the incoming ask-event-time-filter ADR moves to the next free number (0202). All references across AGENTS.md/CLAUDE.md/ARCHITECTURE.md, docstrings, ADR 0150 related links, seed comments, and changelog fragments follow. CHANGELOG.md keeps both the 2.13.0 and 2.15.0 entries in descending order.
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
# Conflicts: # AGENTS.md
# Conflicts: # AGENTS.md # ARCHITECTURE.md # CHANGELOG.d/2.13.0-ask-event-time-filter.md # CHANGELOG.md # CLAUDE.md # backend/app/post_chat_ingestion.py # docs/adr/0150-korean-relative-time-retrieval.md # docs/adr/0183-ask-event-time-filter.md # docs/adr/0201-ask-event-time-filter.md # docs/adr/0202-ask-event-time-filter.md # docs/adr/README.md # lineageweave/temporal_expressions.py # scripts/seed_demo_data.py
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
…ncrement 0202 is now claimed by the ask event-time filter ADR (#581), so this increment takes 0203. Doc conflicts resolve toward main's canonical agent-guide structure while keeping this branch's share sentence and amendment list; CLAUDE.md takes main's restructured section wholesale.
1 participant
Summary
Fixes #569. Global Ask relative-time questions (
어제,그저께,지난주) now bind to the source-system event instant, not record ingestion time (ADR 0168).Bulk imports cluster
created_atnear import time, so어제 무슨 일이 있었나요?used to miss yesterday's events. Ask now comparescoalesce(event_occurred_at, created_at)on the Asia/Seoul calendar. Missing event time falls back tocreated_atand is named as that fallback — never invented.After
make seed, leftover closest/farthest pairs still sit above the member list; a click still opens that post. Ask 어제 무슨 일이 있었나요? on bulk-imported fixtures that share one ingest day keeps the post whose event fell yesterday, drops last week's event, and names Time axis on the cited evidence. Open that cited post to read which clock matched.Decision (ADR 0168)
source_post.event_occurred_at(Allen 1983; W3C Time; PROV-Oprov:generatedAtTimestays oncreated_at).time axis: event occurred atortime axis: record created at.--event-occurred-at-column. Unmapped imports leave the column null.occurred_atonto both clocks so reconstruct and leftover pairs stay on the designed January timeline.created_at.Tests
uv run --python 3.12 --extra dev --with asyncpg pytest tests/test_ask_time_axis.py tests/test_global_ask_sources.py tests/test_post_chat.py tests/test_import_postgresql_posts.py tests/test_temporal_expressions.py— 90 passed, 2 skipped.pnpm exec vitest run src/components/AskEvidenceLayerPopup.test.tsx— 9 passed.Synthetic fixtures only. Independent APPROVE required. Do not self-approve. Squash-merge only with independent APPROVE + exact-head required success.