-
Notifications
You must be signed in to change notification settings - Fork 1
fix(ui-ux): give Event Lineage DAG node marks a 24x24px hit target #554
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
seonghobae
merged 14 commits into
main
from
fix/uiux-touch_interaction-lineage-dag-node-touch-target
Aug 24, 2026
Merged
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
f62c8ff
fix(ui-ux): give Event Lineage DAG node marks a 24x24px hit target
seonghobae 2ecf470
fix(ui-ux): keep the DAG hit circle invisible under the author CSS fi…
seonghobae fb40507
fix(frontend): wire ADR 0109 return-url capture and narrow admin token
seonghobae 689e42e
Merge branch 'main' into fix/uiux-touch_interaction-lineage-dag-node-…
seonghobae e0794c0
Merge branch 'main' into fix/uiux-touch_interaction-lineage-dag-node-…
seonghobae c0be67e
fix(ui-ux): keep focus/hover/current rings off the DAG hit target
seonghobae 677b000
fix(ui-ux): exclude the DAG hit target from focus/hover/current rings
seonghobae c020b86
fix(ui-ux): pin the DAG svg to its user-unit width
seonghobae 38adb83
test(red): require scrollable lineage DAG viewport
seonghobae 141a429
test(red): require mobile lineage scroll guidance
seonghobae 3132682
fix(ui-ux): keep lineage DAG reachable in narrow viewports
seonghobae 84db804
fix(ui-ux): style keyboard-scrollable lineage viewport
seonghobae cb45b87
test(storybook): cover mobile lineage scrolling
seonghobae a650675
docs(storybook): record mobile lineage scroll state
seonghobae File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,27 @@ | ||
| .lineage-dag-scroll-hint { | ||
| display: none; | ||
| margin: 0 0 var(--space-control-gap); | ||
| color: var(--text); | ||
| font-size: 0.8rem; | ||
| } | ||
|
|
||
| .lineage-dag-viewport { | ||
| max-width: 100%; | ||
| overflow-x: auto; | ||
| overflow-y: hidden; | ||
| overscroll-behavior-inline: contain; | ||
| scrollbar-gutter: stable; | ||
| -webkit-overflow-scrolling: touch; | ||
| } | ||
|
|
||
| .lineage-dag-viewport:focus-visible { | ||
| outline: 2px solid var(--color-focus-border); | ||
| outline-offset: 2px; | ||
| border-radius: var(--radius-control); | ||
| } | ||
|
|
||
| @media (max-width: 768px) { | ||
| .lineage-dag-scroll-hint { | ||
| display: block; | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,34 @@ | ||
| import { render, screen } from "@testing-library/react"; | ||
| import { describe, expect, it, vi } from "vitest"; | ||
| import { LineageDag } from "./LineageDag"; | ||
| import type { LineageGraph } from "./api"; | ||
|
|
||
| const wideGraph: LineageGraph = { | ||
| nodes: [ | ||
| { id: "a1", group: "A-100", label: "Initial scope", occurred_at: "2026-01-01T00:00:00Z", is_root: true, is_branch_point: false }, | ||
| { id: "a2", group: "A-100", label: "Terms follow-up", occurred_at: "2026-01-05T00:00:00Z", is_root: false, is_branch_point: false }, | ||
| { id: "a3", group: "A-100", label: "Delivery question", occurred_at: "2026-01-06T00:00:00Z", is_root: false, is_branch_point: false }, | ||
| { id: "a4", group: "A-100", label: "Delivery confirmed", occurred_at: "2026-01-11T00:00:00Z", is_root: false, is_branch_point: false }, | ||
| ], | ||
| edges: [ | ||
| { source: "a1", target: "a2", fused_score: 0.83 }, | ||
| { source: "a2", target: "a3", fused_score: 0.87 }, | ||
| { source: "a3", target: "a4", fused_score: 0.9 }, | ||
| ], | ||
| }; | ||
|
|
||
| describe("LineageDag responsive viewport", () => { | ||
| it("keeps an intrinsically wide DAG inside a named keyboard-focusable viewport", () => { | ||
| render(<LineageDag graph={wideGraph} onSelectPost={vi.fn()} />); | ||
|
|
||
| expect(screen.getByText("Swipe or use arrow keys to inspect the full lineage.")).toBeInTheDocument(); | ||
|
|
||
| const viewport = screen.getByRole("region", { name: "A-100 lineage viewport" }); | ||
| expect(viewport).toHaveAttribute("tabindex", "0"); | ||
| expect(viewport).toHaveClass("lineage-dag-viewport"); | ||
|
|
||
| const svg = screen.getByRole("img", { name: "A-100 lineage" }); | ||
| expect(viewport).toContainElement(svg); | ||
| expect(Number(svg.getAttribute("width"))).toBeGreaterThan(320); | ||
| }); | ||
| }); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.