test: inventory desktop and phone workspace navigation - #510
Merged
seonghobae merged 2 commits intoAug 23, 2026
Merged
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
…ilter' into codex/workspace-nav-storybook
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
seonghobae
merged commit Aug 23, 2026
494ccf5
into
feat/board-source-detail-state-filter
4 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Product result
Storybook now exposes the reusable workspace navigation as interactive desktop and phone-drawer scenes, including current-page semantics and the reader-only drawer without Admin.
Stack
This focused head stacks on PR #490 current base
fc3ea87470dc840e38aa36f9f0c25294c334734c, which owns the ADR 0118 workspace shell and existing Ask Agent scenes. It adds no production abstraction or dependency.What changes
Workspace/WorkspaceNav/Desktopchanges destinations and verifiesaria-current="page"follows the selection.Workspace/WorkspaceNav/PhoneDraweruses the existing phone viewport and verifies the drawer variant omits Admin.All fixtures are synthetic and non-identifying.
Exact-head local verification
Exact head:
1ce7649febc062da9275a5f288c2e048b2d7c1f43 passedgit diff --checkagainst the current parent: passedNo browser-rendered comparison or protected merge is claimed. Independent exact-head review and hosted checks remain required.