Skip to content

fix: preserve channel-weight fallback transaction - #501

Merged
seonghobae merged 2 commits into
docs/customer-master-scope-adrfrom
fix/lineage-weight-fallback-savepoint
Aug 23, 2026
Merged

fix: preserve channel-weight fallback transaction#501
seonghobae merged 2 commits into
docs/customer-master-scope-adrfrom
fix/lineage-weight-fallback-savepoint

Conversation

@seonghobae

@seonghobae seonghobae commented Aug 23, 2026

Copy link
Copy Markdown
Contributor

Summary

  • isolate the optional lineage_channel_weight read in an asyncpg savepoint so a missing rollout table cannot abort the enclosing rebuild transaction
  • add a regression that proves the same connection remains usable after the documented fallback
  • align ADR 0145 and the estimator docstring with fast-mlsirm: factor_id maps channel items to the shared trait; cluster_id carries reconstruction-group nesting

Validation

  • 16 passed, 1 skipped: lineage ingestion, channel estimation, estimator script, and lineage persistence suites
  • Full local suite on the stacked base: 878 passed, 18 skipped, 5 unrelated existing integration failures from local schema/provider drift; not represented as green

Follow-up to #499, which merged before these review fixes reached its head.


Open in Devin Review

@coderabbitai

coderabbitai Bot commented Aug 23, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 4f659409-c0ec-43d8-8d01-6cce2a0625c2

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Devin Review found 1 potential issue.

Open in Devin Review

Comment thread backend/app/lineage_ingestion.py
@seonghobae
seonghobae merged commit 84c2239 into docs/customer-master-scope-adr Aug 23, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant