-
Notifications
You must be signed in to change notification settings - Fork 1
fix(customer-master): open related posts in place instead of jumping to Board #414
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
5e37378
d5d6668
a046da4
b4f12bc
119212e
4edf12d
8684d68
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 📝 Info: Hint filter forces an extra source-context query
(Refers to this code) Was this helpful? React with 👍 or 👎 to provide feedback. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
📝 Info: Reported name can differ from the bound entity
When
get_or_create_corporate_entityfuzzy-matches an existing entity whose stored name differs from the resolved name, the response still returns the resolved name (entity_nameat customer_hint_ingestion.py) rather than the bound entity's catalog name. The old exact-match path always agreed, so this divergence is new. Cosmetic only.Was this helpful? React with 👍 or 👎 to provide feedback.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed in 63768c9: re-fetches the canonical entity_name by corporate_entity_id right before returning, so the response always reports the actually-bound entity's real catalog name instead of the possibly-divergent resolved name. Added a regression test simulating the divergence (fuzzy match binds to an entity whose stored name differs from the resolved name).