-
Notifications
You must be signed in to change notification settings - Fork 1
fix: separate R&R job title, group unanchored orgs, raise Keyman timeout #407
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -178,8 +178,16 @@ class ContextualOrchestratorKeymanExtractionClient: | |
|
|
||
| available = True | ||
|
|
||
| # 2026-08-22 live finding: ``mode="auto"`` can route to deep multi-agent | ||
| # orchestration (Fugu/Conductor/TRINITY test-time compute allocation -- | ||
| # see AGENTS.md's paper-grounded model policy), which legitimately runs | ||
| # past 180s for a long post body. Orchestrator logs showed the request | ||
| # actually completed and then hit BrokenPipeError trying to write the | ||
| # response, because this client had already closed the socket on | ||
| # timeout. Accuracy, not latency, is the requirement here (a real user | ||
| # click, not a hot path), so the timeout is generous rather than tight. | ||
| def __init__( | ||
| self, base_url: str, api_key: str, *, reasoning_effort: str = "auto", timeout: float = 180.0 | ||
| self, base_url: str, api_key: str, *, reasoning_effort: str = "auto", timeout: float = 900.0 | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 📝 Info: 15-minute client timeout depends on upstream limits The client timeout rises 180s->900s (lineageweave/keyman_extraction.py:190). A user-clicked extraction can now hold one HTTP call open for 15 minutes. Any intervening proxy or gateway with a shorter timeout would still cut the connection first, so the real ceiling is the smallest upstream limit. Was this helpful? React with 👍 or 👎 to provide feedback. |
||
| ) -> None: | ||
| self._base_url = base_url.rstrip("/") | ||
| self._api_key = api_key | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
📝 Info: Anchor adopts first member's affiliated catalog id
buildRoleTreepicks the first non-nullaffiliated_organization_catalog_idamong an unanchored org's members (frontend/src/App.tsx:1865-1867). If per-row resolution assigns different catalog ids to the same org name, the shared anchor silently uses one. This matches the documented intent, but relies on resolution being consistent across rows.Was this helpful? React with 👍 or 👎 to provide feedback.