-
Notifications
You must be signed in to change notification settings - Fork 1
fix: preserve stale summary buyer continuity #311
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
seonghobae
merged 37 commits into
fix/project-bound-summary-actions
from
fix/stale-summary-buyer-continuity
Aug 21, 2026
Merged
Changes from all commits
Commits
Show all changes
37 commits
Select commit
Hold shift + click to select a range
d8b7f56
fix: preserve stale summary buyer continuity
seonghobae 2218ee7
fix: keep post content recovery alive
seonghobae b7ed772
test(summary): cover stale continuity and retry
seonghobae c914f76
feat: add explicit post content retry
seonghobae bff4c9d
test(queue): cover explicit retry rejection
seonghobae ba60842
docs(queue): complete retry command docstrings
seonghobae c301e2e
fix: reconcile backfill content with job ledger
seonghobae 4016e2b
fix(ui): preserve indentation after mixed content
seonghobae 20b9177
Merge remote-tracking branch 'origin/fix/stale-summary-buyer-continui…
seonghobae e219e48
docs: record post content recovery evidence
seonghobae 8b0e1d8
docs(ui): clarify indentation matching boundary
seonghobae 5873966
test(ui): cover missing source unit fallback
seonghobae 4bc21e4
fix: serialize per-post vision region analysis
seonghobae 69b96e9
Merge remote-tracking branch 'origin/fix/stale-summary-buyer-continui…
seonghobae d9b4b51
fix: preserve honest image evidence rendering
seonghobae f13bc3f
feat: enrich semantic hints from source catalogs
seonghobae adbb72d
fix: reject non-decomposed vision regions
seonghobae 766b742
docs: refresh protected gate baseline
seonghobae 4d3d7ae
docs: record corrected image region evidence
seonghobae 85dbfb5
fix: trim source catalog lookup codes
seonghobae efd4aab
docs: record catalog hint boundary
seonghobae deca246
docs: record exact-head validation evidence
seonghobae 82b7b39
docs: record live browser acceptance
seonghobae 69b8909
docs: refresh live gate topology
seonghobae a903fff
Merge remote-tracking branch 'origin/fix/project-bound-summary-action…
seonghobae d36e106
Merge remote-tracking branch 'origin/fix/stale-summary-buyer-continui…
seonghobae ab27898
fix: refresh content after summary ingestion
seonghobae 446abeb
Merge remote-tracking branch 'origin/fix/project-bound-summary-action…
seonghobae 36a879b
Merge remote-tracking branch 'origin/fix/stale-summary-buyer-continui…
seonghobae 17ff911
Merge remote-tracking branch 'origin/fix/project-bound-summary-action…
seonghobae e38df62
Merge remote-tracking branch 'origin/fix/stale-summary-buyer-continui…
seonghobae 9357d38
style: normalize summary test imports
seonghobae 815e0c0
Merge project-bound summary actions into stale continuity
seonghobae 50aa037
Merge remote-tracking branch 'origin/fix/project-bound-summary-action…
seonghobae a47a7a9
Merge remote-tracking branch 'origin/fix/stale-summary-buyer-continui…
seonghobae 60878ff
Merge commit '7b8b9d556ca53350bced2328e7900933df8fcd5e' into HEAD
seonghobae 338f028
fix(ui): preserve indentation after mixed content (#314)
seonghobae File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,41 @@ | ||
| import { render, screen } from "@testing-library/react"; | ||
| import { describe, expect, it } from "vitest"; | ||
| import { PostBody } from "./PostBody"; | ||
|
|
||
| describe("PostBody table-source indentation matching", () => { | ||
| it("does not reuse an earlier table cell when a later paragraph has the same text", () => { | ||
| render( | ||
| <PostBody | ||
| body="<table><tr><td>Repeated</td></tr></table><p> Repeated</p>" | ||
| structureUnits={[ | ||
| { | ||
| unit_index: 0, | ||
| unit_kind_code: "dom", | ||
| unit_label: "tr", | ||
| unit_text: "Repeated", | ||
| indent_level: 0, | ||
| indent_source_code: "explicit", | ||
| indent_confidence: 1, | ||
| indent_evidence: "table row", | ||
| }, | ||
| { | ||
| unit_index: 1, | ||
| unit_kind_code: "dom", | ||
| unit_text: "Repeated", | ||
| indent_level: 0, | ||
| indent_source_code: "unresolved", | ||
| indent_confidence: 0, | ||
| indent_evidence: "", | ||
| }, | ||
| ]} | ||
| />, | ||
| ); | ||
|
|
||
| const repeatedNodes = screen.getAllByText("Repeated"); | ||
| const paragraph = repeatedNodes.find((node) => node.tagName === "P"); | ||
|
|
||
| expect(screen.getByRole("table")).toBeInTheDocument(); | ||
| expect(paragraph).toBeDefined(); | ||
| expect(paragraph).toHaveAttribute("data-indent-level", "1"); | ||
| }); | ||
| }); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
📝 Info: Table-cell consumption relies on 1:1 source segment mapping
The loop consumes source segments matching each table cell so a later unresolved paragraph with identical text cannot reuse a cell's segment. This holds because
splitPostBodytreats each<td>as a block boundary (BLOCK_TAG), yielding one segment per cell. If a source shape ever merged cells into one segment, or a same-text paragraph earlier in source order mapped to a structure unit ordered after the table,sourceTextForUnitcould still shift indentation via earliest-unconsumed matching.Was this helpful? React with 👍 or 👎 to provide feedback.