-
Notifications
You must be signed in to change notification settings - Fork 1
fix(ui): name the next action on the cutoff live-body warning (v0.88.0) #171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
seonghobae
wants to merge
2
commits into
feat/analysis-run-live-write-clock
from
cursor/bc-482049cd-0dc4-4e6a-b4e1-acd8b86c8202-4a5e
Closed
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| # 0.88.0 Analysis-run cutoff body warning | ||
|
|
||
| Opening a title marked updated after cutoff now says the popup body is | ||
| live. Compare it with this run before treating it as reconstructed | ||
| evidence. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -1754,6 +1754,48 @@ describe("App, authenticated", () => { | |
| expect(teppHistory).not.toHaveTextContent("Succeeded"); | ||
| }); | ||
|
|
||
| it("warns that a cutoff-rewritten title opens the live body, not a snapshot", async () => { | ||
| stubBackend(); | ||
| render(<App />); | ||
|
|
||
| await userEvent.click( | ||
| await screen.findByRole("button", { | ||
| name: "Open analysis run: Lineage reconstruction · Succeeded · Demo Corp", | ||
| }), | ||
| ); | ||
| await userEvent.click( | ||
| await screen.findByRole("button", { | ||
| name: "Open live post (updated after cutoff): Public post", | ||
| }), | ||
| ); | ||
| await waitFor(() => expect(screen.getByText("The full body text.")).toBeInTheDocument()); | ||
| expect(screen.getByRole("status", { name: "Live body warning" })).toHaveTextContent( | ||
| "This is the live body, not a cutoff snapshot. Compare it with this 2026-01-12 run before you treat it as reconstructed evidence.", | ||
| ); | ||
|
|
||
| await userEvent.click(screen.getAllByRole("button", { name: "Open post: Linked post" })[0]); | ||
| await waitFor(() => | ||
| expect(screen.getByText("The evidence panel should show exactly this text.")).toBeInTheDocument(), | ||
| ); | ||
| expect(screen.queryByRole("status", { name: "Live body warning" })).not.toBeInTheDocument(); | ||
|
|
||
| await userEvent.click(screen.getByRole("button", { name: "Close" })); | ||
| await userEvent.click( | ||
| screen.getByRole("button", { | ||
| name: "Open live post: Private post", | ||
| }), | ||
| ); | ||
| await waitFor(() => | ||
| expect(screen.getByText("The evidence panel should show exactly this text.")).toBeInTheDocument(), | ||
| ); | ||
| expect(screen.queryByRole("status")).not.toBeInTheDocument(); | ||
|
|
||
| await userEvent.click(screen.getByRole("button", { name: "Close" })); | ||
| await userEvent.click(screen.getByRole("button", { name: "View post: Public post" })); | ||
| await waitFor(() => expect(screen.getByText("The full body text.")).toBeInTheDocument()); | ||
| expect(screen.queryByRole("status")).not.toBeInTheDocument(); | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Same AccName as the related-post assertion above. The home list must stay warning-free; the name keeps that check tied to this status. |
||
| }); | ||
|
|
||
| it("does not tell a failed lineage run to connect the measurement service", async () => { | ||
| stubBackend({ failedLineageRun: true }); | ||
| render(<App />); | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -55,4 +55,4 @@ | |
| "sentence_excerpts", | ||
| ] | ||
|
|
||
| __version__ = "0.87.0" | ||
| __version__ = "0.88.0" | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Name Live body warning here too. An unnamed
statusquery fails if the run detail later grows its own live region, even when this popup is honest.