-
Notifications
You must be signed in to change notification settings - Fork 1
fix: keep requester thread-group runs behind the cutoff (v0.86.3) #151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| A thread-group run you requested stays off the home list unless that | ||
| thread has an in-cutoff visible post. Same-named R&R people bind the | ||
| earliest catalog row. |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -4,6 +4,18 @@ All notable changes to this project are documented here. Format follows | |
| [Keep a Changelog](https://keepachangelog.com/en/1.1.0/); versioning follows | ||
| [Semantic Versioning](https://semver.org/spec/v2.0.0.html). | ||
|
|
||
| ## [0.86.3] - 2026-08-16 | ||
|
|
||
| ### Fixed | ||
|
|
||
| - A thread-group analysis-run you requested no longer appears on the | ||
| home list when that thread has no ABAC-visible post at or before | ||
| `knowledge_cutoff` (ADR 0018). Open a thread that has an in-cutoff | ||
| visible post, then request again. Detail of the hidden row is 404. | ||
|
Comment on lines
+11
to
+14
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. “Open a thread … then request again” is not a product path. |
||
| - An R&R person name that matches two catalog rows now binds the | ||
| earliest `created_at`, then `person_id`. A later same-named Keyman | ||
| row no longer steals the mention. | ||
|
|
||
| ## [0.86.2] - 2026-08-16 | ||
|
|
||
| ### Fixed | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -40,6 +40,9 @@ the id by `corporate_entity.entity_name`. | |
|
|
||
| Thread-group run list visibility requires at least one ABAC-visible | ||
| `source_post` whose `created_at` is at or before `knowledge_cutoff`. | ||
| Requester ownership (`requested_by_account_id`) does not bypass that | ||
| clock: a run you requested on a thread that has no in-cutoff visible | ||
| post stays off the home list and returns 404 on detail. | ||
|
|
||
| ## Consequences | ||
|
|
||
|
|
@@ -49,6 +52,9 @@ Thread-group run list visibility requires at least one ABAC-visible | |
| organization chip. | ||
| - A later public post in a thread group no longer lists a January run | ||
| that could not have known that post. | ||
| - Requesting that January run yourself does not put it on your home | ||
| list. Open a thread that has an in-cutoff visible post, then request | ||
| again. | ||
|
Comment on lines
+55
to
+57
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Same dishonest next action. Request still records a corporate-scope lineage run (ADR 0017). The list row appears when the thread already has an in-cutoff visible post. |
||
|
|
||
| ## References | ||
|
|
||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -55,4 +55,4 @@ | |
| "sentence_excerpts", | ||
| ] | ||
|
|
||
| __version__ = "0.86.2" | ||
| __version__ = "0.86.3" | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Important: the recovery sentence overclaims the product.
create_pending_analysis_runstill rejects every scope exceptanalysis_scope_corporate_entity("Other scopes are not available yet."). The home button only POSTsanalysis_run_lineagewith no thread key. Requesting again cannot attach a January thread-group run, and a new corporate run is a different row.The honest next action is: that January row stays off the list until the thread already has an ABAC-visible post at or before
knowledge_cutoff. Same note is indocs/adr/0018-related-nodes-team-org-walk.mdconsequences.