fix(codeql): stage versioned handler rollout bootstrap - #2105
Conversation
|
Warning Review limit reachedNext included review available in 30 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (6)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Exact publication receipt: head |
seonghobae
left a comment
There was a problem hiding this comment.
Exact-head bounded review completed against a5ca9f1c04e73ed653f2bb3ddced4182349edddb / tree c99c98d0ebd2e6dd69bdce8c56cb1d6461cc0e8f. Reviewed the six-file delta and rollout dependency: the handler is the causal owner; matrix shards are read-only; one settlement job owns mutation; rerun schemas fail closed; attempts 48–50 stop before mutation; docs remain Proposed. No additional substantive source finding. This COMMENT is not approval or merge authority; hosted exact-head checks and independent review remain required.
|
@opencode-agent review BandScope downstream prerequisite review request. Read-only review exact |
|
Fresh hosted evidence turns the remaining rollout problem into a concrete bootstrap-cycle finding. Exact |
seonghobae
left a comment
There was a problem hiding this comment.
Exact-head review after non-force protected-main reconciliation: fde889ad611054cad0c1be5a14289b7eb881b124 / tree 8f0819472eba62d570a5e6743737872ed7d25586. The five protected-main commits change disjoint runtime-quality/materializer/queue-documentation paths; the six-file handler delta remains byte-identical. Focused handler contracts: 66 passed; inherited new-main contracts: 2 passed; full suite: 3074 passed, 1 skipped, 36 subtests; compileall and diff-check clean. Production RED remains handler run 34686384371: both scans/status publications succeeded, Actions wake succeeded, Python duplicate wake failed. No additional source finding. This COMMENT is not approval or merge authority.
|
@opencode-agent review Read-only independent review request for exact |
|
@opencode-agent review Fresh exact-head read-only review request for |
|
Canonical successor carryover update: |
|
Verified complete successor carryover before retirement.
Closing this Draft predecessor only because complete successor carryover is mechanically proven. No valid delta is discarded; continue review/repair/merge on #2106. |
Problem
Protected handler run 34686384371 supplies the production RED. Both language shards completed CodeQL analysis, SARIF enforcement, evidence preservation, and authenticated status publication. Actions then woke required run 34685520218; Python's second mutation failed because the required run was already running. This is the protected handler's attempt-wide single-writer defect.
Bounded owner repair
This successor stages only the protected-handler prerequisite:
settle-required-runmutation owner after every language scan;actions: readfor shards andactions: writeonly for settlement;schema: "1"; legacy top-level inputs remain explicitlylegacy-0;RED → GREEN lineage
952f95fe→ GREEN2351dc13: versioned single-writer handler bootstrap.a686a488→ GREEN6308f7aa: settlement cap below the Actions rerun ceiling.c5b8d004,99bc9dbd.fde889ad, with parents prior exact heada5ca9f1cand protectedmain@fb17ef556f94f673234aa557254ae52779e9a7b0.Exact evidence
fde889ad611054cad0c1be5a14289b7eb881b1248f0819472eba62d570a5e6743737872ed7d2558666 passed2 passed3074 passed, 1 skipped, 36 subtests passedcompileallandgit diff --check: cleanAll hosted results for predecessor head
a5ca9f1c...are diagnostic only and do not transfer.Bootstrap and landing gate
Ready is review admission, not approval or merge authorization. This repository's protected
maincurrently requires both CodeQL compatibility contexts, and the production RED exists in the protected handler that produces those contexts. Therefore an admin/expected-head bypass, temporary protection weakening, synthetic success/status publication, no-op freshness commit, Draft/Ready retrigger, or manual rerun storm is not an acceptable bootstrap.Before merge, this owner must establish a normal-protection bootstrap path that lets the unchanged exact head obtain authentic required CodeQL terminal success without trusting mutable PR handler code or weakening repo/PR/base/head/run/job/language/SARIF provenance. If the existing protected handler cannot satisfy that invariant, keep this PR Proposed/Ready-for-review only and document the governance deadlock as such; do not convert the deadlock into bypass authority.
After a qualifying independent current-head review and terminal success for every non-circular exact-head gate, implement or adopt the smallest versioned bootstrap that remains inside normal branch protection, then obtain a fresh exact-head CodeQL generation. Only after #2105 lands normally may #2040 non-force reconcile onto the new protected tip and run a fresh producer → protected-handler canary.
Do not use predecessor evidence, mutable handler source, force update, destructive rebase, predecessor closure, or evidence transfer. Status remains Proposed until normal protected integration and downstream canary evidence.
Canonical successor / lifecycle correction (2026-09-12)
Fresh comparison against protected
main@fb17ef556f94f673234aa557254ae52779e9a7b0shows this exact headfde889ad611054cad0c1be5a14289b7eb881b124and #2106 are divergent implementations of the same protected-handler responsibility. This branch preserves valid single-settlement, schema-validation, rerun-budget, ADR, Gap, and test evidence, but its own landing section still proves the normal-protection bootstrap unresolved.#2106 is the canonical writer because it additionally preserves the legacy v1 title/payload/status boundary, adds a shared v1/v2 concurrency owner, requires v2 producer and ordered merge-parent provenance, documents an explicit v1 removal condition, and carries the denied-credential fallback regression repair. This predecessor was closed only after the canonical successor incorporated its exact head by ordinary two-parent ancestry and the successor comparison proved the complete code, ADR, Gap, fixture, and contract delta preserved. Closure retires the duplicate landing vehicle; it does not mark the protected-main integration complete. No predecessor Checks or review transfer to #2106.