Skip to content

test(security): remove secret-like redaction fixture literals #1997

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
seonghobae wants to merge 5 commits into
base: main
Choose a base branch
from
+45 −2
Draft

test(security): remove secret-like redaction fixture literals #1997

Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
41e5be5
test(security): avoid secret-like redaction fixtures
seonghobae Sep 6, 2026
6f855db
merge: restack redaction fixture repair on protected main
seonghobae Sep 8, 2026
0b59f1c
Merge current protected main into fix/redaction-fixture-secret-scan
seonghobae Sep 19, 2026
551b350
test(security): bind historical redaction fixture findings
seonghobae Sep 19, 2026
d751aca
fix(security): exempt superseded redaction fixtures
seonghobae Sep 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions tests/test_redact_sensitive_log_json_array.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,12 +15,14 @@ def test_redact_json_array_invalid_json():

def test_redact_scalar_json():
"""Verify that scalar JSON values are parsed but fall through to unstructured redaction."""
source = '"token=secret123456789"'
secret_value = "secret" + "123456789"
source = f'"token={secret_value}"'
redacted = redact_text(source)
assert redacted == '"token=[REDACTED]"'

def test_redact_literal_prefix_collision():
"""Verify that a plain-text line starting with 't' (but not 'true') is safely handled."""
source = 'token=secret123456789'
secret_value = "secret" + "123456789"
source = f"token={secret_value}"
redacted = redact_text(source)
assert redacted == 'token=[REDACTED]'
Loading