fix(ci): preserve bounded sidecar diagnostics - #1978
Conversation
Signed-off-by: Seongho Bae <me@seonghobae.me>
|
Warning Review limit reachedNext included review available in 30 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (3)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
추가 독립 측정: exact head5dad3fe874f93b19b232f4452e7190b72655f18e, 전후 worktree clean. Actions 환경 -W error로 기존 preflight 파일134건이11.72초에 통과했습니다. sanitizer 한 모듈만 측정한 coverage는 실행 문장104/104, 분기50/50, 누락/부분분기0입니다. 기존 pragma로 제외된 main 진입점234–235행 두 줄은 그대로이며 새 제외 규칙을 추가하지 않았습니다. 따라서 제외 없는 전체 저장소100%나 모든 입력 조합 검증이라는 뜻은 아닙니다. 보고서 /tmp/cwl-sidecar-coverage.f1HySS/coverage.json. 새로운 테스트 조건을 통과시키려고 보안 필터·coverage 기준·기존 gate를 낮추지 않았습니다. |
|
Exact-head 검증 추가: 5dad3fe874f93b19b232f4452e7190b72655f18e에서 GITHUB_ACTIONS=true pytest tests -q -W error 전체 실행이 2997 passed, 1 skipped, 21 subtests passed / 201.99초 / exit 0으로 종료했습니다. 실행 전후 HEAD 동일, 작업 트리 clean, stderr 0 bytes를 직접 확인했습니다. 로컬 원본 기록: /tmp/cwl-pr1978-full.6ZO4qH. 제외 1개를 통과로 계산하지 않습니다. Hosted 검사는 별개입니다. Strix run 34045630626 job 101526823503은 internal_error HTTP 500(request_id 25970859f26b4662a6d2091496a515ad) 후 authoritative vulnerability analysis 불가로 exit 1입니다. CodeQL actions job 101526846114는 DISPATCH_OUTCOME=success, VERDICT_STATE=pending 후 의도된 exit 1이며 취약점 검출 결과가 아닙니다. 어느 것도 성공으로 간주하거나 수동 재실행으로 덮지 않았습니다. 보호 병합과 실제 배포 검증은 미완료입니다. |
seonghobae
added
bug
ChatGPT Codex Connector
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![opencode-agent[bot]](https://avatars.githubusercontent.com/in/1549082?s=60&v=4){kind=small}
There was a problem hiding this comment.
Pull request overview
OpenCode could not approve from deterministic current-head evidence because GitHub Checks have failed.
Findings
1. HIGH Current-head GitHub Checks - Fix failed required checks before approval
- Problem: Failed same-head checks remain for
3431353843cd3572dcde5c81237e541d0ab59d12. - Root cause: The model-unavailable evidence fallback is allowed only when peer GitHub Checks are complete and clean.
- Fix: Read and fix the failed check logs below, then rerun the current-head checks.
- Regression test: Keep the model-unavailable fallback gated on an empty failed-check rollup.
Failed checks:
- Required Noema Review/noema-review: FAILURE (https://github.com/ContextualWisdomLab/.github/actions/runs/34310168911/job/102336283140)
- noema-review check run: failure (https://github.com/ContextualWisdomLab/.github/actions/runs/34310168911/job/102336283140)
Changed-File Evidence Map
flowchart LR
PR["PR changed files"] --> Evidence["OpenCode bounded evidence"]
Evidence --> S1["Repository file: AGENTS.md"]
S1 --> I1["repository behavior"]
I1 --> R1["Review risk: Repository file: AGENTS.md"]
R1 --> V1["required checks"]
Evidence --> S2["CI script: sanitize_contextual_orchestrator_sidecar_stream.py"]
S2 --> I2["review and security gate shell path"]
I2 --> R2["Review risk: CI script: sanitize_contextual_orchestrator_sidecar_stream.py"]
R2 --> V2["bash -n plus Strix self-test"]
Evidence --> S3["Test: test_contextual_orchestrator_review_runtime_preflight.py"]
S3 --> I3["regression suite"]
I3 --> R3["Review risk: Test: test_contextual_orchestrator_review_runtime_preflight.py"]
R3 --> V3["targeted test run"]
OpenCode Review Overview
|
…he central collector Explicit user-authorized bypass for contextual-orchestrator infrastructure recovery. Prerequisite #1978 merged at 7b16449; retargeted this unchanged head to main without rewriting history. Full four-file diff reviewed; zero inline review threads. Exact-head CodeQL 34311014133, Security Scan 34311014127 and SAST 34311014150 are success; prior branch-based test claims are not fresh main/consumer evidence. Admit only 32-lowercase-hex server request IDs and contract-specific absence markers; retain legacy records and omit error text. Success summaries restricted to fixed review paths. No expanded auth, raw log publication, scanner suppression or synthetic statuses. Paired producer contextual-orchestrator#1105 is merged at 650bb67dd9cb9b0846a9026dd829c82f43b839e8. No independent approval or live incident-restoration claim.
1 participant
변경
CO 진단의
provider_status와 서버 생성request_id를 중앙 sanitizer가 보존하도록 수정합니다. 기존 형식은 유지하고 원문 메시지·URL·본문은 계속 제외합니다. 요청 이벤트는 bare 형식 또는 서버 logger 접두사에서만 인정하며 잘못된 필드·부분 매칭·여러 줄 입력은 거절합니다.AGENTS.md에는 producer 단위 테스트만으로 CI artifact 보존을 주장하지 말고 exact revision 쌍을 검증하라는 지침을 추가했습니다.exact-head 검증
3431353843cd3572dcde5c81237e541d0ab59d127fd571dbcdbae6acf29d8f4ee704d7ba6297e4db을 비강제 merge로 restack-W error: runtime-preflight 134개 통과git diff --check: 통과경계
원문 응답 재출력, 권한 확대, retry 또는 timeout 변경은 없습니다. 보호 병합과 실제 배포 증거는 hosted exact-head checks 후에만 성립합니다.