chore(ci): retire completed PR1714/PR1715 source-fix assets - #1723
Conversation
|
Warning Review limit reachedNext included review available in 46 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Team Run ID: 📒 Files selected for processing (4)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Single-writer reconciliation finding: this PR's live diff currently removes only the two one-shot workflow files, despite the body claiming four artifacts. Earlier canonical cleanup #1721 is based on the same protected |
|
Current-head single-writer check on |
|
Successor state changed while this lane was being revalidated. |
Preserve the complete PR1723 history while reconciling onto protected main@63bf49835da44aa8257eb76a92368e6485ae6e94 without force-push or rebase. The resulting tree is current main plus deletion of exactly the four completed PR1714/PR1715 one-shot workflow/driver assets; it intentionally preserves current-main tests and all concurrent commits. Repository search confirms each retired driver is executed only by its matching completed source-fix workflow, while valid production repairs remain carried by live successors #1718 and #1720.
|
This classification authorizes at most the narrow owner bypass boundary for this exact SHA. It does not transfer predecessor evidence, weaken any required context, approve #1718/#1720, or authorize bypass of a later substantive finding. Any merge must use |
Preserve the verified central-run read-authority repair while taking current protected main as the authoritative tree, including #1728 dependency-review documentation and #1723 retirement of completed PR1714/PR1715 source-fix assets. Reapply only #1717's four-file semantic delta. Keep both histories without force push or destructive rebase.
Purpose
Retire the completed PR #1714 / PR #1715 one-shot repair machinery after proving its only executable callers are the two matching source-fix workflows and preserving every still-valid production delta in live canonical successor PRs.
Current exact-head state — 2026-09-02
main@63bf49835da44aa8257eb76a92368e6485ae6e94;f98f8bbc670e582672317bc4458314a68ff67e93;Current effective delta
The intended durable delta deletes exactly four bounded one-shot assets:
.github/workflows/source-fix-pr1714-no-model-job-timeout.ymlscripts/ci/source_fix_pr1714_no_model_job_timeout.py.github/workflows/source-fix-pr1715-no-model-job-timeout.ymlscripts/ci/source_fix_pr1715_no_model_job_timeout.pyA concurrent writer briefly added the PR1714 autofix contract test to this cleanup branch. That was a single-writer violation because canonical successor #1718 owns that production/test contract. Commit
f98f8bbc670e582672317bc4458314a68ff67e93restorestests/test_pr_review_autofix_writer_security_contract.pyto blob3f6119424fcca7724fa2cc5258ecf4b661d2788c, exactly the blob on protectedmain@63bf4983.... The path can still appear in merge-base-oriented PR history, but it has no net tree delta against the live protected base.The temporary
PR1723 Carryover Repairworkflow was removed rather than becoming a second production writer. Every still-valid production delta remains completely carried by live canonical successors:ContextualWisdomLab/.github#1718@8e5b54eafa562903880677755d8db98096352b7cowns the PR1714/no-heuristics production repair. It has been non-destructively reconciled with protectedmain@63bf4983..., is ahead-only (behind_by=0), and includes.github/workflows/pr-review-autofix.yml, its regression contract, CHANGELOG/product-gap traceability, and completed PR1714 source-fix retirement;ContextualWisdomLab/.github#1720@683c40ba8055517330293733f64a58ea33b1bbb8owns the PR1715/Noema local-deadline repair, its tests/documentation, and the complete retirement delta.Those successors remain open Draft/Proposed and must integrate through their own ordinary protection. This cleanup does not declare them complete, consume their mutable implementation, or discard their valid deltas.
Caller / lifecycle proof
Protected
mainstill contains both source-fix workflows and drivers. Repository code search established each driver is executed only by its matching one-shot workflow; neither workflow exposesworkflow_callor a live product caller. PR #1714 and PR #1715 are already merged, and the remaining valid behavior changes are preserved in #1718/#1720. Removing the four workflow/driver files together therefore orphans no supported caller and removes completed self-modifying verification debt.Original coverage incident
Exact-head
ContextualWisdomLab/.github#1717verification run33619132165, job100211833192, reached repository-wide verification with2629 passed, 1 skipped, 21 subtests passedbut reported 99% coverage because the two completed materializer scripts contributed 86 uncovered statements (46 + 40). Their retained executable source is verification debt after responsibility moved to the canonical successor PRs.Merge boundary
Do not transfer predecessor evidence or bypass a substantive test/security/review/provenance failure. Ordinary auto-merge may complete only after this exact head has terminal required Checks, current review state and protected-base reconciliation. #1718 and #1720 stay alive until their respective production deltas integrate through ordinary protection; this cleanup must never become their production writer.