Skip to content

chore(ci): retire completed PR1714/PR1715 source-fix assets - #1723

Merged
seonghobae merged 13 commits into
mainfrom
cleanup/retire-merged-source-fix-1714-1715-20260902
Sep 2, 2026
Merged

chore(ci): retire completed PR1714/PR1715 source-fix assets#1723
seonghobae merged 13 commits into
mainfrom
cleanup/retire-merged-source-fix-1714-1715-20260902

Conversation

@seonghobae

@seonghobae seonghobae commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

Purpose

Retire the completed PR #1714 / PR #1715 one-shot repair machinery after proving its only executable callers are the two matching source-fix workflows and preserving every still-valid production delta in live canonical successor PRs.

Current exact-head state — 2026-09-02

  • protected base: main@63bf49835da44aa8257eb76a92368e6485ae6e94;
  • exact head: f98f8bbc670e582672317bc4458314a68ff67e93;
  • open / Ready / mergeable with ordinary auto-merge enabled; exact-head security/review workflows have materialized and are currently queued, therefore non-passing;
  • all currently fetched inline review threads are resolved from current-source evidence; thread resolution is not approval and predecessor checks/reviews do not transfer.

Current effective delta

The intended durable delta deletes exactly four bounded one-shot assets:

  • .github/workflows/source-fix-pr1714-no-model-job-timeout.yml
  • scripts/ci/source_fix_pr1714_no_model_job_timeout.py
  • .github/workflows/source-fix-pr1715-no-model-job-timeout.yml
  • scripts/ci/source_fix_pr1715_no_model_job_timeout.py

A concurrent writer briefly added the PR1714 autofix contract test to this cleanup branch. That was a single-writer violation because canonical successor #1718 owns that production/test contract. Commit f98f8bbc670e582672317bc4458314a68ff67e93 restores tests/test_pr_review_autofix_writer_security_contract.py to blob 3f6119424fcca7724fa2cc5258ecf4b661d2788c, exactly the blob on protected main@63bf4983.... The path can still appear in merge-base-oriented PR history, but it has no net tree delta against the live protected base.

The temporary PR1723 Carryover Repair workflow was removed rather than becoming a second production writer. Every still-valid production delta remains completely carried by live canonical successors:

  • ContextualWisdomLab/.github#1718@8e5b54eafa562903880677755d8db98096352b7c owns the PR1714/no-heuristics production repair. It has been non-destructively reconciled with protected main@63bf4983..., is ahead-only (behind_by=0), and includes .github/workflows/pr-review-autofix.yml, its regression contract, CHANGELOG/product-gap traceability, and completed PR1714 source-fix retirement;
  • ContextualWisdomLab/.github#1720@683c40ba8055517330293733f64a58ea33b1bbb8 owns the PR1715/Noema local-deadline repair, its tests/documentation, and the complete retirement delta.

Those successors remain open Draft/Proposed and must integrate through their own ordinary protection. This cleanup does not declare them complete, consume their mutable implementation, or discard their valid deltas.

Caller / lifecycle proof

Protected main still contains both source-fix workflows and drivers. Repository code search established each driver is executed only by its matching one-shot workflow; neither workflow exposes workflow_call or a live product caller. PR #1714 and PR #1715 are already merged, and the remaining valid behavior changes are preserved in #1718/#1720. Removing the four workflow/driver files together therefore orphans no supported caller and removes completed self-modifying verification debt.

Original coverage incident

Exact-head ContextualWisdomLab/.github#1717 verification run 33619132165, job 100211833192, reached repository-wide verification with 2629 passed, 1 skipped, 21 subtests passed but reported 99% coverage because the two completed materializer scripts contributed 86 uncovered statements (46 + 40). Their retained executable source is verification debt after responsibility moved to the canonical successor PRs.

Merge boundary

Do not transfer predecessor evidence or bypass a substantive test/security/review/provenance failure. Ordinary auto-merge may complete only after this exact head has terminal required Checks, current review state and protected-base reconciliation. #1718 and #1720 stay alive until their respective production deltas integrate through ordinary protection; this cleanup must never become their production writer.

@coderabbitai

coderabbitai Bot commented Sep 2, 2026

Copy link
Copy Markdown

Warning

Review limit reached

Next included review available in 46 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Team

Run ID: 0aa7f3cc-c507-4d2c-9419-d0859a5b11f9

📥 Commits

Reviewing files that changed from the base of the PR and between 63bf498 and 2358a96.

📒 Files selected for processing (4)
  • .github/workflows/source-fix-pr1714-no-model-job-timeout.yml
  • .github/workflows/source-fix-pr1715-no-model-job-timeout.yml
  • scripts/ci/source_fix_pr1714_no_model_job_timeout.py
  • scripts/ci/source_fix_pr1715_no_model_job_timeout.py

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@seonghobae
seonghobae enabled auto-merge (squash) September 2, 2026 10:31
devin-ai-integration[bot]

This comment was marked as resolved.

@seonghobae seonghobae added area: ci-cd CI, GitHub Actions, checks, release, or supply chain priority: medium Normal-priority or P2 work status: blocked Blocked by conflict, dependency, or required prerequisite type: maintenance Maintenance, build, dependency, or operational upkeep labels Sep 2, 2026 — with ChatGPT Codex Connector

Copy link
Copy Markdown
Contributor Author

Single-writer reconciliation finding: this PR's live diff currently removes only the two one-shot workflow files, despite the body claiming four artifacts. Earlier canonical cleanup #1721 is based on the same protected main@5935c8153722fe6b53bafd579b74f8f097303959 and its live diff removes all four claimed artifacts (both workflows plus both materializer scripts). Keep this lane blocked/non-landing while #1721 remains the complete cleanup writer. Do not retire either history solely from narrative; after #1721 integrates, re-read protected main and verify all four paths are absent before treating #1723's two-file delta as completely carried.

devin-ai-integration[bot]

This comment was marked as resolved.

Copy link
Copy Markdown
Contributor Author

Current-head single-writer check on ec798fc9b1761c49efc43f7ae8e32381cbcc87e2: this branch does not yet match its stated retirement contract. Relative to protected main@5935c8153722fe6b53bafd579b74f8f097303959, it deletes only the two workflow files, still leaves both completed scripts/ci/source_fix_pr1714_no_model_job_timeout.py and scripts/ci/source_fix_pr1715_no_model_job_timeout.py, and adds another temporary .github/workflows/_temp_pr1723_carryover_repair.yml. The earlier canonical cleanup lane #1721 is based on the same protected main and its exact current diff deletes all four completed assets and adds nothing. Please treat #1723 as not merge-ready unless its writer finishes/self-removes the temporary repair and proves a unique delta not already carried by #1721. I attempted to convert this PR back to Draft, but the connected GitHub lifecycle mutation failed before GitHub mutation because its wrapper queries nonexistent Repository.fullDatabaseId; no lifecycle state was changed. Do not transfer checks between these heads.

Copy link
Copy Markdown
Contributor Author

Successor state changed while this lane was being revalidated. ContextualWisdomLab/.github#1721 has now been retired after verified complete transfer into Draft successor #1720 exact head 0339dbc4c75b9e6e1be972ad9d76ca2c498138d0. Exact comparison of #1720 against protected main@5935c8153722fe6b53bafd579b74f8f097303959 proves it deletes all four intended PR1714/PR1715 temporary assets (both workflow files and both scripts/ci/source_fix_*.py materializers), while #1723 current head still carries an extra temporary workflow and does not delete the two scripts. No unique valid product/control-plane delta exists on #1723 beyond that fully carried cleanup requirement. I am therefore retiring this duplicate lane only under the verified-successor rule; #1720 remains Draft/Proposed and must earn its own exact-head Checks/reviews before ordinary integration. No #1723 Check evidence transfers.

@seonghobae seonghobae closed this Sep 2, 2026
auto-merge was automatically disabled September 2, 2026 10:48

Pull request was closed

@seonghobae seonghobae reopened this Sep 2, 2026
@seonghobae
seonghobae enabled auto-merge (squash) September 2, 2026 12:11
devin-ai-integration[bot]

This comment was marked as resolved.

Preserve the complete PR1723 history while reconciling onto protected main@63bf49835da44aa8257eb76a92368e6485ae6e94 without force-push or rebase. The resulting tree is current main plus deletion of exactly the four completed PR1714/PR1715 one-shot workflow/driver assets; it intentionally preserves current-main tests and all concurrent commits. Repository search confirms each retired driver is executed only by its matching completed source-fix workflow, while valid production repairs remain carried by live successors #1718 and #1720.

Copy link
Copy Markdown
Contributor Author

QUEUE_SATURATION_CHICKEN_EGG revalidation before any exceptional merge, 2026-09-02:

  • protected base is still main@63bf49835da44aa8257eb76a92368e6485ae6e94;
  • exact current PR head is 2358a965f5b3629a2cf5f051eb6296f9cc3812e2, produced by a non-force two-parent reconciliation that preserves the prior PR history and protected-main history;
  • GitHub reports the current head mechanically mergeable; effective delta is exactly four deletions, 0 additions: the completed PR1714/PR1715 one-shot workflow/driver pairs;
  • repository search established each driver has no executable caller beyond its matching completed source-fix workflow; valid PR1714/PR1715 production requirements remain completely carried by live canonical successors fix(autofix): repair no-heuristics regression merged by #1714 #1718 and fix(noema): remove unsupported local job deadlines #1720 and are not being discarded or claimed complete here;
  • all currently visible inline review threads are resolved; no current substantive CHANGES_REQUESTED/security/test/provenance defect is present. CodeRabbit is rate-limited on this exact four-file deletion review rather than reporting a source finding; Devin remains pending, not a failing finding;
  • every fetched exact-head Actions run is queued/pending (CodeQL, Scorecard, Semgrep, OSV, Python Security, Secret Scan, Security Scan, SBOM); no completed failing exact-head run was observed;
  • central Actions is currently 1969 queued / 1 in_progress, so this head's remaining admission evidence cannot start under the saturated fleet.

This classification authorizes at most the narrow owner bypass boundary for this exact SHA. It does not transfer predecessor evidence, weaken any required context, approve #1718/#1720, or authorize bypass of a later substantive finding. Any merge must use expected_head_sha=2358a965f5b3629a2cf5f051eb6296f9cc3812e2; if the head/base moves or a substantive failure appears, this classification expires immediately.

@seonghobae
seonghobae merged commit f246193 into main Sep 2, 2026
7 of 25 checks passed
@seonghobae
seonghobae deleted the cleanup/retire-merged-source-fix-1714-1715-20260902 branch September 2, 2026 12:33
seonghobae added a commit that referenced this pull request Sep 2, 2026
Preserve the verified central-run read-authority repair while taking current protected main as the authoritative tree, including #1728 dependency-review documentation and #1723 retirement of completed PR1714/PR1715 source-fix assets. Reapply only #1717's four-file semantic delta. Keep both histories without force push or destructive rebase.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: ci-cd CI, GitHub Actions, checks, release, or supply chain priority: medium Normal-priority or P2 work status: blocked Blocked by conflict, dependency, or required prerequisite type: maintenance Maintenance, build, dependency, or operational upkeep

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant