-
Notifications
You must be signed in to change notification settings - Fork 0
fix(scheduler): lengthen scan-pr-queue's own heartbeat, don't drop it #1704
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -31,3 +31,23 @@ def test_repository_scheduler_keeps_event_driven_wakes() -> None: | |
| assert "pull_request_review:" in workflow | ||
| assert "workflow_run:" in workflow | ||
| assert "repository_dispatch:" in workflow | ||
|
|
||
|
|
||
| def test_scan_pr_queue_heartbeat_is_hourly_and_offset_not_removed() -> None: | ||
| """scan-pr-queue's own repository-local heartbeat must not be dropped. | ||
|
|
||
| org-queue-sweep excludes ContextualWisdomLab/.github from its target | ||
| list by name, so scan-pr-queue's own cron is the sole periodic fallback | ||
| for this repository's PR queue (and for any required check, such as | ||
| Security Scan or SAST Semgrep, with no workflow_run listener anywhere in | ||
| this file). It must be lengthened to hourly for the same capacity reason | ||
| as org-queue-sweep, not deleted, and offset from org-queue-sweep's | ||
| "0 * * * *" tick so the two heartbeats do not collide. | ||
| """ | ||
| workflow = WORKFLOW.read_text(encoding="utf-8") | ||
| assert '- cron: "30 * * * *"' in workflow | ||
| assert '*/30 * * * *' not in workflow | ||
| schedule_block = workflow.split(" schedule:", 1)[1].split( | ||
| " repository_dispatch:", 1 | ||
| )[0] | ||
| assert schedule_block.count('- cron:') == 2 | ||
|
Comment on lines
+47
to
+53
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
📝 Info: Schedule routing remains mutually exclusive
The
30 * * * *event runs only the repository scan;0 * * * *remains reserved for the organization sweep. Their concurrency keys also differ.(Refers to this code)
Was this helpful? React with 👍 or 👎 to provide feedback.