fix(opencode): replace probe quota with exact changed-path evidence - #1701
Draft
seonghobae wants to merge 2 commits into
Draft
Conversation
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Root cause
Fresh central-owner audit found a remaining OpenCode model-evidence admission heuristic in both
ci-review-prompt.mdandscripts/ci/opencode_review_prompt_template.md: formal approval required two falsified probes for source/workflow/config/package/test changes and one for non-code changes. The rule allocates review effort from file/change-type names and fixed integers, with no cited statistical model, experiment, standard, or provider contract establishing those counts.RED-first repair
Commit
3be4b597d61a5879a94e7aaec7c92af0248886a0addstests/test_opencode_no_heuristic_review_evidence.py, requiring the two-versus-one rule to disappear and formal review evidence to use the exact current-head changed-path set as its deterministic evidence universe. Incomplete exact evidence must fail closed withNEEDS_INFO, never degrade to an informal smaller quota.Commit
e8880d8f107f57268d8a3ba53317565368eef20eadds an exact-head, self-retiring source-fix workflow. It replaces the count/name-based admission text in both central prompts, updatesdocs/product-technical-gap-baseline.mdandCHANGELOG.md, runs focused review-policy tests plus the repository test suite, and publishes only if the writer head is unchanged.Stack / ownership
This PR is stacked on
.github#1629because #1629 is the canonical central review-admission/routing owner and is still carrying its own no-heuristic compute repairs. This child remains Draft until the parent delta is integrated and exact-head checks are terminal GREEN. No force push, destructive rebase, self-approval, or gate bypass is used.