Skip to content

fix(opencode): replace probe quota with exact changed-path evidence - #1701

Draft
seonghobae wants to merge 2 commits into
fix/no-heuristic-review-admission-current-mainfrom
fix/opencode-exact-evidence-no-heuristics
Draft

fix(opencode): replace probe quota with exact changed-path evidence#1701
seonghobae wants to merge 2 commits into
fix/no-heuristic-review-admission-current-mainfrom
fix/opencode-exact-evidence-no-heuristics

Conversation

@seonghobae

Copy link
Copy Markdown
Contributor

Root cause

Fresh central-owner audit found a remaining OpenCode model-evidence admission heuristic in both ci-review-prompt.md and scripts/ci/opencode_review_prompt_template.md: formal approval required two falsified probes for source/workflow/config/package/test changes and one for non-code changes. The rule allocates review effort from file/change-type names and fixed integers, with no cited statistical model, experiment, standard, or provider contract establishing those counts.

RED-first repair

Commit 3be4b597d61a5879a94e7aaec7c92af0248886a0 adds tests/test_opencode_no_heuristic_review_evidence.py, requiring the two-versus-one rule to disappear and formal review evidence to use the exact current-head changed-path set as its deterministic evidence universe. Incomplete exact evidence must fail closed with NEEDS_INFO, never degrade to an informal smaller quota.

Commit e8880d8f107f57268d8a3ba53317565368eef20e adds an exact-head, self-retiring source-fix workflow. It replaces the count/name-based admission text in both central prompts, updates docs/product-technical-gap-baseline.md and CHANGELOG.md, runs focused review-policy tests plus the repository test suite, and publishes only if the writer head is unchanged.

Stack / ownership

This PR is stacked on .github#1629 because #1629 is the canonical central review-admission/routing owner and is still carrying its own no-heuristic compute repairs. This child remains Draft until the parent delta is integrated and exact-head checks are terminal GREEN. No force push, destructive rebase, self-approval, or gate bypass is used.

@coderabbitai

coderabbitai Bot commented Sep 2, 2026

Copy link
Copy Markdown

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@seonghobae seonghobae added area: ci-cd CI, GitHub Actions, checks, release, or supply chain bug Something isn't working priority: high High-priority or P1 work status: draft Draft pull request type: bug Defect or incorrect behavior labels Sep 2, 2026 — with ChatGPT Codex Connector
- .github/workflows/source-fix-1701-opencode-evidence-admission.yml

permissions:
contents: write
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: ci-cd CI, GitHub Actions, checks, release, or supply chain bug Something isn't working priority: high High-priority or P1 work status: draft Draft pull request type: bug Defect or incorrect behavior

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants