-
Notifications
You must be signed in to change notification settings - Fork 0
fix(noema): do not fail closed-but-current-head as stale #1674
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
seonghobae
wants to merge
52
commits into
main
Choose a base branch
from
fix/noema-closed-not-stale
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
52 commits
Select commit
Hold shift + click to select a range
3adadfe
fix(noema): do not fail closed-but-current-head as stale
seonghobae 82c467b
docs(gap-baseline): correct stale #1672 read in the 2026-09-02 triage…
07ce4af
test(strix): reproduce closed/draft repository-dispatch race
seonghobae a16f5d3
ci: materialize PR1674 Strix live-state repair
seonghobae c7a30b2
ci: retrigger PR1674 live-state materializer
seonghobae 4e7f186
chore(ci): remove inert PR1674 trigger marker
seonghobae 6ecfdd3
fix(noema): finalize closed-target skip contract
seonghobae 146a89d
fix(actions): finalize PR1674 with reviewable Noema source
seonghobae 474bfd7
fix(actions): use available slim runner for PR1674 verification
seonghobae 0d72f85
fix(noema): gate setup and publication on live PR state
seonghobae 710bf3f
test(noema): lock live-target admission boundaries
seonghobae a8395f6
chore(noema): retire self-modifying PR1674 workflow
seonghobae 89f2e54
chore(noema): remove covered PR1674 finalizer
seonghobae bcd380c
test(noema): correct live-target contract assertions
seonghobae c3cb6f0
ci: retry PR1674 live-state repair off saturated runner lane
seonghobae 8c91568
ci: extract PR1674 live-state repair helper
seonghobae c4436c8
ci: repair PR1674 one-shot workflow syntax and deps
seonghobae 5cc84e4
test(strix): create preflight fixture parents
seonghobae 6325dd9
test(noema): cover private cross-repo live admission
seonghobae ce511f6
ci: extend PR1674 repair to live private Noema admission
seonghobae 1370e03
fix(ci): complete PR1674 live-authority repair helper
seonghobae 7d72dbf
ci: repair PR1674 exact-head publication contract
seonghobae 2900d7b
ci: publish PR1674 workflow repair with workflow-capable credential
seonghobae 0332792
ci: mint writer credential for PR1674 publication
seonghobae 4e908ab
fix(review): revalidate live dispatch targets before admission
github-actions[bot] 48d7649
test(noema): require fresh private publication authority
seonghobae 3c6552e
test(strix): require skip signal across status job
seonghobae 54c7e59
fix(review): materialize exact-head Noema/Strix follow-up repairs
seonghobae 81ac01e
ci: run PR 1674 exact-head follow-up repair
seonghobae 9a4ccbd
fix(noema): refresh scoped authority before publication checks
seonghobae 8c32fb3
fix(strix): propagate live skip across status job
seonghobae adac9c1
chore(review): retire completed PR1674 repair driver
seonghobae d6fb678
chore(review): retire completed PR1674 repair workflow
seonghobae 3451e90
test(noema): extend token lifetime contract through private publication
seonghobae 3a43906
docs(noema): close private publication authority lifetime contract
seonghobae 5a62dc0
docs(adr): record fresh publication authority and live-skip boundary
seonghobae 12ebe14
docs(architecture): define review publication and live-skip boundaries
seonghobae 08fb49c
test(strix): require late live status revalidation
seonghobae 087b058
test(strix): require fresh late status authority
seonghobae a5bb0bf
docs(adr): keep review publication authority decision proposed
seonghobae 74c5355
fix(strix): add exact late-publication repair driver
seonghobae 9c479ae
ci(strix): stage verified PR1674 publication repair
seonghobae ceeeb4e
ci(strix): coalesce PR1674 repair onto one slim runner
seonghobae 59fa59d
repair(review): stage PR1674 exact-head findings
seonghobae fe73b59
repair(review): execute exact-head PR1674 findings before materializa…
seonghobae 8156aca
fix(review): repair PR1674 exact-head bridge anchors
seonghobae 6fb3175
fix(review): install Strix hash-locked test runtime for PR1674
seonghobae c007901
fix(review): isolate PR1674 repair lock environments
seonghobae d93e6d1
fix(review): use declared Strix verification environment
seonghobae 83f580a
fix(review): compose locked Strix test environment
seonghobae ce6f519
test(strix): align stale-event contract with late-bound authority
seonghobae 0dcf33b
test(strix): preserve dual-event admission semantics
seonghobae File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
133 changes: 133 additions & 0 deletions
133
.github/workflows/_temp_pr1674_status_publication_repair.yml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,133 @@ | ||
| # One-shot owner-branch repair; self-deletes after verified non-force publication. | ||
| name: Temporary PR1674 Strix publication authority repair | ||
|
|
||
| on: | ||
| push: | ||
| branches: [fix/noema-closed-not-stale] | ||
| paths: | ||
| - .github/workflows/_temp_pr1674_status_publication_repair.yml | ||
| - scripts/ci/pr1674_status_publication_repair.py | ||
| - scripts/ci/pr1674_exact_findings_repair.py | ||
| - .github/workflows/strix.yml | ||
| - .github/workflows/noema-review.yml | ||
| - tests/test_strix_repository_dispatch_live_state.py | ||
| - tests/test_noema_live_target_admission.py | ||
|
|
||
| concurrency: | ||
| group: temp-pr1674-status-publication-${{ github.repository }}-${{ github.ref_name }} | ||
| cancel-in-progress: true | ||
|
|
||
| permissions: | ||
| contents: read | ||
|
|
||
| jobs: | ||
| repair: | ||
| if: >- | ||
| github.repository == 'ContextualWisdomLab/.github' && | ||
| github.event_name == 'push' && | ||
| github.ref == 'refs/heads/fix/noema-closed-not-stale' | ||
| runs-on: ubuntu-slim | ||
| steps: | ||
| - name: Checkout exact writer head | ||
| uses: actions/checkout@9c091bb21b7c1c1d1991bb908d89e4e9dddfe3e0 # v7.0.0 | ||
| with: | ||
| ref: ${{ github.sha }} | ||
| fetch-depth: 0 | ||
| persist-credentials: false | ||
|
|
||
| - name: Set up review Python 3.14 | ||
| id: review_python | ||
| uses: actions/setup-python@5fda3b95a4ea91299a34e894583c3862153e4b97 # v7.0.0 | ||
| with: | ||
| python-version: '3.14' | ||
|
|
||
| - name: Set up Strix Python 3.13 | ||
| id: strix_python | ||
| uses: actions/setup-python@5fda3b95a4ea91299a34e894583c3862153e4b97 # v7.0.0 | ||
| with: | ||
| python-version: '3.13' | ||
|
|
||
| - name: Install hash-locked test dependencies in isolated environments | ||
| run: | | ||
| set -euo pipefail | ||
| "${{ steps.review_python.outputs.python-path }}" -m venv "$RUNNER_TEMP/review-venv" | ||
| "$RUNNER_TEMP/review-venv/bin/python" -m pip install \ | ||
| --disable-pip-version-check --require-hashes --only-binary=:all: \ | ||
| -r requirements-opencode-review-ci-hashes.txt | ||
| "${{ steps.strix_python.outputs.python-path }}" -m venv "$RUNNER_TEMP/strix-venv" | ||
|
devin-ai-integration[bot] marked this conversation as resolved.
|
||
| # Match the declared Strix workflow: the generated lock fully pins and hashes | ||
| # transitive artifacts, while --no-deps avoids re-solving declared ranges that | ||
| # intentionally conflict with the reviewed exact lock. | ||
| "$RUNNER_TEMP/strix-venv/bin/python" -m pip install \ | ||
| --disable-pip-version-check --require-hashes --no-deps --only-binary=:all: \ | ||
| -r requirements-strix-ci-hashes.txt | ||
|
devin-ai-integration[bot] marked this conversation as resolved.
|
||
|
|
||
| - name: Revalidate exact writer head | ||
| env: | ||
| EXPECTED_HEAD: ${{ github.sha }} | ||
| run: | | ||
| set -euo pipefail | ||
| test "$(git rev-parse HEAD)" = "$EXPECTED_HEAD" | ||
| remote_head="$(git ls-remote origin "refs/heads/${GITHUB_REF_NAME}" | awk '{print $1}')" | ||
| test -n "$remote_head" | ||
| test "$remote_head" = "$EXPECTED_HEAD" | ||
| test -f scripts/ci/pr1674_status_publication_repair.py | ||
| test -f scripts/ci/pr1674_exact_findings_repair.py | ||
| test -f .github/workflows/_temp_pr1674_status_publication_repair.yml | ||
|
|
||
| - name: Materialize exact-head review finding repairs | ||
| run: | | ||
| set -euo pipefail | ||
| "${{ steps.review_python.outputs.python-path }}" scripts/ci/pr1674_exact_findings_repair.py | ||
| test ! -e scripts/ci/pr1674_exact_findings_repair.py | ||
| "${{ steps.review_python.outputs.python-path }}" -m py_compile scripts/ci/pr1674_status_publication_repair.py | ||
| git diff --check | ||
|
|
||
| - name: Materialize late-bound Strix publication authority | ||
| run: | | ||
| set -euo pipefail | ||
| "${{ steps.review_python.outputs.python-path }}" scripts/ci/pr1674_status_publication_repair.py | ||
| test ! -e scripts/ci/pr1674_status_publication_repair.py | ||
| test ! -e .github/workflows/_temp_pr1674_status_publication_repair.yml | ||
| git diff --check | ||
|
|
||
| - name: Verify executable live-state and transport contracts | ||
| run: | | ||
| set -euo pipefail | ||
| # The Strix lock intentionally mirrors the production --no-deps install and | ||
| # therefore does not carry pytest. Use the review lock's pinned pytest while | ||
| # importing Strix/PyYAML from the exact Python 3.13 Strix environment. | ||
| strix_site_packages="$("$RUNNER_TEMP/strix-venv/bin/python" -c 'import site; print(site.getsitepackages()[0])')" | ||
| PYTHONPATH="$strix_site_packages:." "$RUNNER_TEMP/review-venv/bin/python" -m pytest \ | ||
| tests/test_strix_repository_dispatch_live_state.py \ | ||
| -q | ||
| PYTHONPATH=. "$RUNNER_TEMP/review-venv/bin/python" -m pytest \ | ||
| tests/test_noema_live_target_admission.py \ | ||
| tests/test_required_workflow_queue_contract.py \ | ||
| -q | ||
| "$RUNNER_TEMP/strix-venv/bin/python" - <<'PY' | ||
| import yaml | ||
| from pathlib import Path | ||
| for path in (Path('.github/workflows/strix.yml'), Path('.github/workflows/noema-review.yml')): | ||
| yaml.safe_load(path.read_text(encoding='utf-8')) | ||
| PY | ||
| "${{ steps.review_python.outputs.python-path }}" -m compileall -q tests/test_strix_repository_dispatch_live_state.py tests/test_noema_live_target_admission.py | ||
| git diff --check | ||
|
|
||
| - name: Publish one exact non-force canonical successor | ||
| env: | ||
| EXPECTED_HEAD: ${{ github.sha }} | ||
| WORKFLOW_PUSH_TOKEN: ${{ secrets.PR_REVIEW_MERGE_TOKEN || secrets.OPENCODE_APPROVE_TOKEN }} | ||
| run: | | ||
| set -euo pipefail | ||
| test -n "$WORKFLOW_PUSH_TOKEN" | ||
| remote_head="$(git ls-remote origin "refs/heads/${GITHUB_REF_NAME}" | awk '{print $1}')" | ||
| test "$remote_head" = "$EXPECTED_HEAD" | ||
| git config user.name github-actions[bot] | ||
| git config user.email 41898282+github-actions[bot]@users.noreply.github.com | ||
| git add -A | ||
| git diff --cached --check | ||
| test -n "$(git diff --cached --name-only)" | ||
| git commit -m "fix(review): close live authority and OIDC transport races" | ||
| git remote set-url origin "https://x-access-token:${WORKFLOW_PUSH_TOKEN}@github.com/${GITHUB_REPOSITORY}.git" | ||
| git push origin "HEAD:refs/heads/${GITHUB_REF_NAME}" | ||
|
devin-ai-integration[bot] marked this conversation as resolved.
|
||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.