test(actions): isolate GitHub-hosted runner admission - #1652
Closed
seonghobae wants to merge 2 commits into
Closed
Conversation
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Incident boundary
Issue #712 still has independent exact-current-head jobs queued before any step or checkout:
ContextualWisdomLab/ConceptWeave#5@ed22957471f7c62b644f68e4f37bdb86327d8668, Product run33562998629, job100039652518: requested labelubuntu-24.04,runner_id=0, empty runner identity and zero steps;ContextualWisdomLab/ConceptWeave#6@7657222d8004191f4a5dffd23cfa6f51d5d6adb5, Product run33563608323, job100041625887: requested labelubuntu-24.04,runner_id=0, empty runner identity and zero steps; andContextualWisdomLab/.github#1643@a1f0e77143e1121414b2fbf6080fdd209137020f, run33566686450, job100051373011: requested labelubuntu-24.04,runner_id=0, empty runner identity and zero steps.Those jobs have no matrix, environment approval or executed dependency. The dependency-review HTTP A/B hypothesis cannot be evaluated until its job first acquires a runner.
Test-first diagnostic
Base is protected
main@cfcde258dc2836838d00982ed812dd3b9d6072ca; exact head at PR creation isdd2c20bccefa604f972caf61900a26f942cc80a0.RED was observed locally with the permanent contract present and the workflow absent: all three tests failed at the missing canary boundary. GREEN then passed after adding the bounded workflow.
The canary deliberately has only:
pull_requestevents bounded to its own workflow and contract paths;ubuntu-latest;needs, environment, credential or job environment;permissions: {};run: "true"step;This isolates hosted-runner admission from source checkout, reusable workflows, dependency APIs, credentials, environments and repository code. It does not mutate any leaf source head and does not weaken a required gate.
Interpretation and lifecycle
runner_id=0with zero steps while the three cited jobs remain queued, treat organization/hosted-runner capacity, scheduler, quota or billing/control-plane availability as the leading boundary and inspect the authorized settings plane.No self-approval, bypass, synthetic status or predecessor evidence is requested.
Refs #712, #810, #1643.