fix(strix): keep required smoke independent from AGENTS prose - #1650
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
Warning Review limit reachedNext included review available in 32 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Team Run ID: 📒 Files selected for processing (2)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
|
Root cause
ContextualWisdomLab/learning-content-studiorun33550889631, job99999752053never reached Strix installation or scanning. The central required-path smoke test exited first because it required the exact non-executable sentenceStrix uses the zero-cost \orchestrator/free`inAGENTS.md. Current guidance already records the same route as “OpenCode, Noema, and Strix all use the fail-closed zero-cost pool \orchestrator/free`”, but the wording and line wrapping differ.That made organization-wide Strix availability depend on one exact documentation phrase. A prose edit could therefore skip every downstream install, scan, report, and status step even when the executable workflow, gateway route, ZDR requirement, permissions, dependency locks, and gate scripts were valid.
Test-first repair
587c4a6dd0d5556bb96c140833c272160fcce85eadds the regression first. A copied, otherwise-valid required-smoke fixture replaces onlyAGENTS.mdprose and requires the smoke test to continue. Against the protected base implementation it reproduces the incident and exits 1 with the same missing-sentence diagnostic.87d825182a37a732a503e9f7a480b13eb3f25e0bremoves only the runtime read/assertion ofAGENTS.mdfromstrix_required_workflow_smoke.sh.5905197e6ef0410d74debe3ac3e35ce71df97b98bounds the fixture subprocess and tightens the separate documentation assertion:Strix,zero-cost, andorchestrator/freemust appear together in one normalized paragraph.This keeps documentation drift testable in central quality CI without blocking consumer security scans on exact wording.
Scope and invariants
Base:
main@83ae03f67ebaef5ac2840fb9b7c3bffc72e20508Head:
5905197e6ef0410d74debe3ac3e35ce71df97b98Diff: 2 files, 3 commits, 83 additions, 2 deletions.
Unchanged:
STRIX_MODEL=contextual-orchestrator/orchestrator/free;Local verification
Repository guidance agrees with the binding Strix route.bash -n scripts/ci/strix_required_workflow_smoke.shsucceeded.python3 -m py_compile tests/test_strix_required_smoke_availability.pysucceeded.python3 -m unittest -v tests/test_strix_required_smoke_availability.py— 2 tests passed.Hosted exact-head Checks and reviews remain authoritative. After protected-main integration, the affected Learning Content Studio PR must acquire a new Strix run; the historical failed job is not reclassified as passing evidence.