Skip to content

fix(tests): repair docs-index probe test JSON fixture regression on main #1636

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
seonghobae wants to merge 1 commit into from
+5 −1
Closed

fix(tests): repair docs-index probe test JSON fixture regression on main #1636

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion tests/test_repository_metadata_reconciliation.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -226,7 +226,11 @@ def test_pages_and_docs_probes(monkeypatch) -> None:
RECONCILER._pages_exists("Repo")

responses = iter(
[completed(), completed(code=1, out="Not Found"), completed(code=1, err="boom")]
[
completed(out=json.dumps({"type": "file"})),
completed(code=1, out="Not Found"),
completed(code=1, err="boom"),
]
Comment on lines +229 to +233

@devin-ai-integration devin-ai-integration Bot Sep 1, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📝 Info: Fixture now matches the file probe's JSON-body contract

On a returncode-0 response, _repository_file_exists runs json.loads on stdout, so the old empty-stdout success fixture raised JSONDecodeError instead of returning True. The {"type":"file"} body now exercises the True branch and matches the shape already used in test_repository_file_probe_requires_a_regular_file.

Devin Review

Was this helpful? React with 👍 or 👎 to provide feedback.

)
monkeypatch.setattr(
RECONCILER.subprocess, "run", lambda *args, **kwargs: next(responses)
Expand Down
Loading