ci(metadata): allow reviewed manual reconciliation - #1626
Closed
seonghobae wants to merge 1 commit into
Closed
Conversation
|
Warning Review limit reachedNext included review available in 6 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Team Run ID: 📒 Files selected for processing (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This was referenced Sep 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Outcome
This lane is closed rather than merged. Exact-head repository validation proved that adding
workflow_dispatchto a central workflow violates the existing control-plane contracttest_no_central_workflow_exposes_branch_selected_manual_dispatch, whose purpose is to ensure central manual entrypoints cannot load branch-selected code.The metadata reconciler already has a trusted default-branch scheduled apply path. Repository-facing settings work should therefore converge through protected-main integration plus the existing schedule, while the dedicated credential repair (#1625) and workflow-backed Pages preservation repair (#1628) remain the owner-side capability fixes.
No governance or test was weakened to make manual dispatch pass. The failed head
085d1f111a13a346e76838ba8f52c958647888b0is retained as evidence of the rejected design.