-
Notifications
You must be signed in to change notification settings - Fork 0
fix(metadata): require dedicated repository settings credential #1625
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
c301f30
test(metadata): require dedicated settings credential
seonghobae 545490a
fix(metadata): isolate repository settings credential
seonghobae 5e3ee2d
merge(main): reconcile dedicated metadata credential repair
seonghobae 4e71985
merge(main): keep dedicated metadata credential repair current
seonghobae 197dbe4
docs(metadata): bind reconciliation to dedicated settings credential
seonghobae bdc389a
chore(metadata): reconcile dedicated settings credential with current…
seonghobae bc3edee
merge(metadata): align dedicated credential lane with current main
seonghobae File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,18 @@ | ||
| """Static contracts for the privileged repository metadata workflow.""" | ||
|
|
||
| from pathlib import Path | ||
|
|
||
|
|
||
| ROOT = Path(__file__).resolve().parents[1] | ||
| WORKFLOW = ROOT / ".github" / "workflows" / "repository-metadata-reconcile.yml" | ||
|
|
||
|
|
||
| def test_metadata_apply_uses_dedicated_least_privilege_credential() -> None: | ||
| """Repository settings writes must not reuse the review/merge credential.""" | ||
| source = WORKFLOW.read_text(encoding="utf-8") | ||
|
|
||
| assert "secrets.CWL_REPOSITORY_METADATA_TOKEN" in source | ||
| apply_source = source.split(" apply:", 1)[1] | ||
| assert "secrets.PR_REVIEW_MERGE_TOKEN" not in apply_source | ||
| assert "Require dedicated repository settings credential" in apply_source | ||
| assert 'test -n "${GH_TOKEN}"' in apply_source | ||
|
seonghobae marked this conversation as resolved.
seonghobae marked this conversation as resolved.
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.