fix(noema): ground formal verdicts in exact changed-line manifest - #1612
fix(noema): ground formal verdicts in exact changed-line manifest#1612seonghobae wants to merge 4 commits into
Conversation
Capture the BandScope #1122 failure where the third reviewed-line coordinate is outside the parsed diff, and require one authoritative LEFT/RIGHT coordinate manifest on both the first request and repair retry.
Provide the model with a deterministic, compact JSON manifest of every allowed path, diff side, and inclusive changed-line range on both initial and repair requests. Preserve the existing fail-closed post-response validator without coordinate snapping, filtering, or verdict downgrade.
|
Warning Review limit reachedNext included review available in 2 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Team Run ID: 📒 Files selected for processing (4)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
QUEUE_SATURATION_CHICKEN_EGG: exact head 1e121e0 is a one-file test-only coverage repair with RED/GREEN/full-suite evidence, zero review threads, Devin no-issues and CodeRabbit/Devin success; remaining required workflows are queued under central Actions saturation. This repair is prerequisite evidence infrastructure for #1612.
|
The Opened #1658 with the one-line fix ( Claude-Session: https://claude.ai/code/session_019YgmaEKnPhrsbSyQBierFH Generated by Claude Code |
|
Both dependencies this PR's Claude-Session: https://claude.ai/code/session_019YgmaEKnPhrsbSyQBierFH Generated by Claude Code |
|
Naruon consumer-path advancement from fresh live state: dependency #1610 is now merged, but this PR is still open with head Please also include the existing Naruon #1613 canary in post-merge acceptance: |
Incident
BandScope PR #1122 failed in Noema job
99792663163with:Here,
line 3is the thirdreviewed_linesitem. The strict validator correctly rejected a model-produced coordinate that was not present on the corresponding side of the unified diff.Root cause
noema_review_gate.pyalready parsed the authoritative(path, line, side)set, but the model received only the raw diff and one schema example. The repair retry repeated a generic “use exact changed-side locations” instruction without exposing the permitted coordinates. A long-running retry could therefore make the same class of coordinate guess again.Repair
LEFT/RIGHTinclusive ranges;reviewed_lines, adversarial probes, and findings;The deterministic post-response validator remains unchanged and fail-closed. This patch does not snap, coerce, filter, or silently discard invalid coordinates, and does not downgrade a formal verdict to obtain a green check.
TDD evidence
116 passed;2342 passed, 1 skipped, 21 subtests passed;scripts/ci:11019statements,4440branches,0missed,0partial, 100%;git diff --checkgates passed.Verification run: https://github.com/ContextualWisdomLab/.github/actions/runs/33514831758
Dependency and rollout
PR #1610 is a separate test-only repair for a protected-main Strix coverage regression discovered while running the full suite. It must land first so this PR's repository-wide
coverage-evidencecheck reflects the Noema change rather than that pre-existing baseline gap.After both PRs merge, rerun Noema against BandScope PR #1122 and require a fresh exact-head verdict before considering the production incident closed.