Skip to content

test(strix): align installer publication contract with GITHUB_ENV - #1607

Merged
seonghobae merged 1 commit into
mainfrom
fix/strix-installer-test-contract-20260901
Sep 1, 2026
Merged

test(strix): align installer publication contract with GITHUB_ENV#1607
seonghobae merged 1 commit into
mainfrom
fix/strix-installer-test-contract-20260901

Conversation

@seonghobae

@seonghobae seonghobae commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

Root cause

Protected main@5d1b9b2109991689d02301fb3577a4d79dbe386f carries a stale Strix installer regression. install_strix_timeout_compat.main() correctly calls _append_github_environment(arguments.github_env, launcher, arguments.scripts_root), but test_installer_main_composes_validation_install_and_publication still expects the pre---github-env two-argument call.

This is not inferred from a leaf failure: exact-head hosted Strix Changed Path Quality run 33511168588, job 99866895872, executed the full repository suite on .github#1606@0b7da69ecd70b5953699ccbbb46b9a0479f59ccd and produced exactly one failure after 2,344 passing tests: this stale assertion. The same stale assertion is present byte-for-byte on protected main, while protected-main production already uses the three-argument publication call.

Repair

Update only that assertion to require (github_env, installed, scripts_root). This preserves the stronger identity/publication contract rather than weakening production to satisfy an obsolete test.

Verification boundary

The hosted failure is the RED evidence. Fresh exact-head quality/security evidence on this PR is authoritative for GREEN; no predecessor status is promoted to passing. If this one-line current-main correction is mechanically mergeable with no substantive review/security finding and its only remaining admission blockers are queued behind the saturated central Actions fleet, it is eligible for the documented QUEUE_SATURATION_CHICKEN_EGG path because the stale protected-main test currently fails the shared full-suite quality lane for unrelated PRs.


Devin Review

@coderabbitai

coderabbitai Bot commented Sep 1, 2026

Copy link
Copy Markdown

Warning

Review limit reached

Next included review available in 53 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Team

Run ID: 2d18beb1-04eb-45b6-bac8-1d6dcc7fb483

📥 Commits

Reviewing files that changed from the base of the PR and between 5d1b9b2 and d36e686.

📒 Files selected for processing (1)
  • tests/test_strix_llm_timeout_contract.py

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no bugs or issues to report.

Devin Review

Copy link
Copy Markdown
Contributor Author

QUEUE_SATURATION_CHICKEN_EGG verified on exact head d36e6860bbc5964e3cfb8dd65337b86fd357efa6: protected main itself contains the stale one-line assertion, and exact-head #1606 Strix quality run 33511168588 proved it is the sole full-suite failure after 2,344 passing tests. This PR changes only that assertion to match the already-protected three-argument _append_github_environment(github_env, launcher, scripts_root) production contract. GitHub reports mergeable, current-head Devin and CodeRabbit statuses are success, there are zero review threads, and all eight current-head required workflows are queued while the repository has 894 queued runs. No product/security/provenance behavior is bypassed; landing this repair removes a protected-main defect that is currently failing unrelated PR quality evidence.

@seonghobae
seonghobae merged commit c70b081 into main Sep 1, 2026
19 of 36 checks passed
@seonghobae
seonghobae deleted the fix/strix-installer-test-contract-20260901 branch September 1, 2026 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant