test(strix): align installer publication contract with GITHUB_ENV - #1607
Conversation
|
Warning Review limit reachedNext included review available in 53 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Team Run ID: 📒 Files selected for processing (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
|
Root cause
Protected
main@5d1b9b2109991689d02301fb3577a4d79dbe386fcarries a stale Strix installer regression.install_strix_timeout_compat.main()correctly calls_append_github_environment(arguments.github_env, launcher, arguments.scripts_root), buttest_installer_main_composes_validation_install_and_publicationstill expects the pre---github-envtwo-argument call.This is not inferred from a leaf failure: exact-head hosted Strix Changed Path Quality run
33511168588, job99866895872, executed the full repository suite on.github#1606@0b7da69ecd70b5953699ccbbb46b9a0479f59ccdand produced exactly one failure after 2,344 passing tests: this stale assertion. The same stale assertion is present byte-for-byte on protected main, while protected-main production already uses the three-argument publication call.Repair
Update only that assertion to require
(github_env, installed, scripts_root). This preserves the stronger identity/publication contract rather than weakening production to satisfy an obsolete test.Verification boundary
The hosted failure is the RED evidence. Fresh exact-head quality/security evidence on this PR is authoritative for GREEN; no predecessor status is promoted to passing. If this one-line current-main correction is mechanically mergeable with no substantive review/security finding and its only remaining admission blockers are queued behind the saturated central Actions fleet, it is eligible for the documented
QUEUE_SATURATION_CHICKEN_EGGpath because the stale protected-main test currently fails the shared full-suite quality lane for unrelated PRs.