test(scheduler): close #1541's 99% coverage regression on main - #1551
test(scheduler): close #1541's 99% coverage regression on main#1551seonghobae wants to merge 4 commits into
Conversation
main currently sits at 99% coverage (fail_under = 100), not caused by this branch: pr_review_fix_scheduler.py's inspect_pr() has two unexercised skip paths for a conflicted PR (draft, and not-authorized-for-repair), and pr_review_merge_scheduler.py's fetch_workflow_names_by_check_suite_rest() (added by #1541, never directly tested) has no coverage for a non- permission RuntimeError propagating, a row with a check_suite_id but no workflow name being skipped, or pagination continuing past a full page. Verified the same 99% gap reproduces on origin/main alone before writing these tests. Carried onto this branch so #1537 can pass its own 100% coverage gate without waiting on a separate fix PR to merge first; also opening that fix directly against main.
|
Warning Review limit reachedNext included review available in 16 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Team Run ID: 📒 Files selected for processing (34)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
|
@opencode-agent review exact head |
|
Superseded by #1554 after #1546 merged to protected main. During an attempted non-force two-parent synchronization of this pre-#1546 branch, compare immediately exposed that the candidate merge commit reused the stale branch tree and would have omitted the newly merged #1546 review-control-plane files. Protected main was never modified. I repaired this branch with a forward child commit using the exact protected-main tree; |
Pull request was closed
Adds a dated traceability entry for the coverage gap this PR closes: root cause (#1546's uncovered additions plus the older #1547/#1551/ #1554 gap, neither of which merged or transfers evidence here), the fix and its verification, the resolved Devin false-positive on sub-clause coverage, and the known pre-existing SIGPIPE test flake left unremediated as out of scope.
2 participants
Root cause
Protected
mainat44a3c740f7c46c06e7500174d4127413f3f581ebcarries a 99%scripts/cicoverage regression introduced by merged #1541 (fix(governance): dispatch failed-check RCA directly). The same missing lines reproduce from protected main alone; this branch closes that central regression rather than adding a member-repository workaround.Canonical consolidation
This PR is the canonical root owner after fresh patch comparison and ordinary stacking:
Resource not accessible by integration -> {}contract while propagating unrelated REST failures;c858ee4065dbda73b38150c95b635c0db7266a39, preserving its unique direct-RCA regression plus CHANGELOG and G-13 product-gap traceability;c858ee4065dbda73b38150c95b635c0db7266a39.The resulting current delta is five files: the two canonical scheduler test modules, the direct-RCA regression module,
CHANGELOG.md, anddocs/product-technical-gap-baseline.md.Covered missing paths
scripts/ci/pr_review_fix_scheduler.py::inspect_pr: conflicted draft and conflicted unauthorized-for-auto-resolution returns;scripts/ci/pr_review_merge_scheduler.py::fetch_workflow_names_by_check_suite_rest: pagination, missing workflow-name filtering, permission-denied empty-map behavior, and unrelated failure propagation;Evidence boundary
The pre-stack local evidence on the original root commit showed 100%
scripts/cicoverage and 100% docstrings, but it is predecessor evidence after #1548 merged into this branch. Current-head hosted checks and review must be regenerated and are the only landing evidence.The latest Devin inline item on current head is informational (
draftand conflict cases reach distinct gates) and its review thread is resolved. It is not an independent approval. A current-head OpenCode review has been requested once; do not spam unchanged reviewer work.Merge gate
Merge only through ordinary protected governance after the unchanged current exact head has every live required check terminal-success, zero valid unresolved findings/threads, and a qualifying independent non-author approval satisfying the live last-push rule. Queued, in-progress, skipped-required, failed, predecessor-head, protected-base, author/self, model-only, synthetic, or administrative-bypass evidence is non-passing. Do not weaken coverage, review, or security gates to land this repair.