fix(scheduler): dispatch reviews after thread updates - #1496
Conversation
Signed-off-by: Seongho Bae <me@seonghobae.me>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthrough
Changes리뷰 이벤트 트리거
Estimated code review effort: 1 (Trivial) | ~5 minutes Merge Risk: 🔵 Low · up to Review submission and dismissal events will now activate the privileged scheduler and downstream review dispatch, fixing missed processing but expanding who can cause that work to run. The change is mergeable with owner awareness that reviewer authorization, fork-origin permissions, and resource-abuse limits should be explicitly validated. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Full details: Docstring CoverageExplanation Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 3 functions across 1 files. (1 skipped: 1 unsupported.) ✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
![cwl-noema-review[bot]](https://avatars.githubusercontent.com/u/295022177?s=60&v=4){kind=small}
There was a problem hiding this comment.
Noema LLM review
The PR addresses the issue of review threads not being dispatched after thread updates, and the changes are correctly applied to the workflow file and test file.
Findings
-
No blocking findings.
-
Result: APPROVE
-
Head SHA:
0dad21eccc53a049ebb3c56f28fda063d97fa38c -
Reviewer credential:
noema-review-github-app -
Actor:
cwl-noema-review[bot]
![opencode-agent[bot]](https://avatars.githubusercontent.com/in/1549082?s=60&v=4){kind=small}
There was a problem hiding this comment.
Pull request overview
OpenCode could not approve from deterministic current-head evidence because GitHub Checks have failed.
Findings
1. HIGH Current-head GitHub Checks - Fix failed required checks before approval
- Problem: Failed same-head checks remain for
7d222285221bc488a3b8e228228907ba9bf9d5a1. - Root cause: The model-unavailable evidence fallback is allowed only when peer GitHub Checks are complete and clean.
- Fix: Read and fix the failed check logs below, then rerun the current-head checks.
- Regression test: Keep the model-unavailable fallback gated on an empty failed-check rollup.
Failed checks:
- Required Noema Review/noema-review: FAILURE (https://github.com/ContextualWisdomLab/.github/actions/runs/33374562818/job/99439685015)
- Strix Security Scan/strix workflow run: cancelled (https://github.com/ContextualWisdomLab/.github/actions/runs/33374562861)
- noema-review check run: failure (https://github.com/ContextualWisdomLab/.github/actions/runs/33374562818/job/99439685015)
Changed-File Evidence Map
flowchart LR
PR["PR changed files"] --> Evidence["OpenCode bounded evidence"]
Evidence --> S1["Workflow: pr-review-merge-scheduler.yml"]
S1 --> I1["GitHub Actions review job"]
I1 --> R1["Review risk: Workflow: pr-review-merge-scheduler.yml"]
R1 --> V1["actionlint plus required checks"]
Evidence --> S2["Test: test_required_workflow_queue_contract.py"]
S2 --> I2["regression suite"]
I2 --> R2["Review risk: Test: test_required_workflow_queue_contract.py"]
R2 --> V2["targeted test run"]
OpenCode Review Overview
|
|
@cwl-noema-review |
|
@opencode-agent Please review the exact current head |
|
Fresh protected-main revalidation after #1546: @opencode-agent review |
|
@opencode-agent current-main convergence pass. Protected main is now |
|
@opencode-agent review Re-review current exact head. Verify the supported |
|
@opencode-agent review exact current head |
|
@cwl-noema-review Please re-review exact head |
|
@opencode-agent Re-review exact head |
|
@cwl-noema-review Re-review exact head |
Dismissed as stale infrastructure evidence, not as approval. This review's only blocking finding was the failed Noema/Strix rollup from predecessor central workflow source. Noema's malformed-verdict and transport failure paths have since landed on protected .github/main@a8c43b4150446105651c1009343cc242c6e44932; a fresh exact-head Noema review has been requested. Do not carry the predecessor failure forward as a current substantive code objection.
|
Chicken-and-egg bypass decision for exact head
This is therefore a self-referential review-dispatch blocker, not a substantive test/security/review defect. I am using the repository's authorized OrganizationAdmin bypass to break only this cycle. After landing I will re-check central main and dependent leaf review dispatches immediately. |
Preserve current central main including the #1496 authorized scheduler cycle-break and #1566 Noema transport fixes, while removing the completed PR #827 one-shot repair workflow/driver and only its dedicated coverage fixture. No live materialization tests are removed. Signed-off-by: Seongho Bae <me@seonghobae.me>
Per the repo owner's exact-current handoff comment on this PR: records the downstream four-pillars#38 required opencode-review failure (central review-control-plane liveness -- the then-fixed 180x30s current-head-verdict wait exhausted, not a downstream product/permissions/security issue), the two already-shipped central repairs that own it (#1546 removing fixed wall-clock cutoffs, #1496 adding pull_request_review to the guarded review-dispatch path), current-main re-verification, and the recovery action taken (fresh exact-head review-only invocation, safe rerun, new queued job/check). No predecessor-head evidence transferred; the original failure is recorded as closed-and-explained incident history only. Also merges main (docs/product-technical-gap-baseline.md was the only conflict -- an append-only doc, both sides' entries kept in encountered order) to clear the branch's stale base and dirty mergeable state. Verified: tests/test_product_technical_gap_baseline.py -- 5 passed; PYTHONPATH=. python -m pytest tests -- 2271 passed, 1 skipped, 21 subtests, 2 pre-existing failures in tests/test_contextual_orchestrator_review_policy.py (test_build_catalog_applies_account_cap, test_build_catalog_respects_limit) confirmed reproducing identically against vanilla origin/main before this merge -- unrelated to this docs-only change, not fixed here. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01BV96rXhqoR3tYZ9AeAVur4
1 participant
Root cause: pull_request_review starts the scheduler but was omitted from TRIGGER_REVIEWS, so resolving the last review thread woke a run that could only block on a missing exact-head OpenCode verdict. This adds that existing event to the guarded review-dispatch path and a regression contract. Evidence: #1466 run 33365291052 at 16bbe7d blocked with zero active threads; #1493 run 33364601591 at 17fd291 also could not dispatch from its review event. Verification: 69 queue-contract tests passed; 54 OpenCode contract tests passed; scheduler self-test, actionlint, and diff check passed; repository suite reached 2117 passed, 1 skipped, 21 subtests, with one environment-only missing-pip failure that passed in an isolated seeded project venv. No approval, merge, branch update, or bypass is performed.
Summary by CodeRabbit
새 기능
버그 수정