chore(ci): pin sidecar to discovery retry - #1469
Conversation
Advance the shared review sidecar to the exact contextual-orchestrator revision that retries transient per-account model discovery failures. Signed-off-by: Seongho Bae <me@seonghobae.me> Commit-Message-Assisted-by: Claude (via Claude Code)
|
Warning Review limit reachedNext included review available in 45 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (4)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
| set -euo pipefail | ||
|
|
||
| ORCHESTRATOR_PIN_SHA="${ORCHESTRATOR_PIN_SHA:-0adca4703df67f8f31d3ea5b04a1e07ed775dd6c}" | ||
| ORCHESTRATOR_PIN_SHA="${ORCHESTRATOR_PIN_SHA:-c107e3e52371993aa9c326fcc245e01c41fc3850}" |
There was a problem hiding this comment.
🔴 Discovery retries exceed startup deadline
Each transient account failure under ORCHESTRATOR_PIN_SHA adds 5.5 seconds without extending the 180-second startup deadline. Healthy review routes can be killed during preflight.
Prompt for agents
The c107e3e runtime adds one 0.5-second-delayed discovery retry with a timeout of up to five seconds for each provider account, but scripts/ci/contextual_orchestrator_review_sidecar.sh still terminates startup after 180 seconds. contextual_orchestrator_review_launcher.py already documents that discovery plus route probing can require 265 seconds before these retries; five retries increase that bound by 27.5 seconds. Reconcile the shell watchdog and launcher budgets, preferably with one shared monotonic startup deadline or scaled probing, so transient discovery recovery cannot consume time that the subsequent preflight is not allowed to use. Update the timeout contract tests and budget documentation with the new pinned runtime's retry allowance.
Was this helpful? React with 👍 or 👎 to provide feedback.
| set -euo pipefail | ||
|
|
||
| ORCHESTRATOR_PIN_SHA="${ORCHESTRATOR_PIN_SHA:-0adca4703df67f8f31d3ea5b04a1e07ed775dd6c}" | ||
| ORCHESTRATOR_PIN_SHA="${ORCHESTRATOR_PIN_SHA:-c107e3e52371993aa9c326fcc245e01c41fc3850}" |
There was a problem hiding this comment.
📝 Info: Pin range contains one commit
The new SHA directly descends from the old pin. No unrelated intervening revisions enter the vendored runtime.
Was this helpful? React with 👍 or 👎 to provide feedback.
| 1. **Vendoring, pinned**: `scripts/ci/contextual_orchestrator_review_sidecar.sh` | ||
| clones `ContextualWisdomLab/contextual-orchestrator` at an exact SHA | ||
| (`0adca4703df67f8f31d3ea5b04a1e07ed775dd6c` today) into `RUNNER_TEMP`. The | ||
| (`c107e3e52371993aa9c326fcc245e01c41fc3850` today) into `RUNNER_TEMP`. The |
There was a problem hiding this comment.
📝 Info: Auto-pool text is historical
The ADR amendment explicitly supersedes its original orchestrator/auto decision. Current workflows and contracts consistently enforce orchestrator/free.
Was this helpful? React with 👍 or 👎 to provide feedback.
1 participant
Summary
0adca470to contextual-orchestratorc107e3e5model_groupcontract from fix(ci): keep sidecar credential accounts independent #1468Runtime motivation
The #1468 Noema proof exposed all five credentials and completed successfully, but Bytez discovery returned HTTP 500. The new exact pin retries that class of transient discovery failure once without collapsing or failing over explicit credential accounts.
Validation
28 passedin the sidecar contract suitegit diff --check