Skip to content

fix(strix): align required-path smoke fallback assertions with the gpt-5.4 contract #1318

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
seonghobae merged 1 commit into from
Aug 25, 2026
Merged

fix(strix): align required-path smoke fallback assertions with the gpt-5.4 contract #1318

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions scripts/ci/strix_required_workflow_smoke.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -170,8 +170,8 @@ assert_file_contains "$full_gate_test" "assert_strix_workflow_pr_trigger_hardene
assert_file_contains "$workflow_file" "nvidia_nim/nvidia/nemotron-3-super-120b-a12b" "Strix defaults public scans to the current hosted NVIDIA NIM model"
assert_file_contains_either \
"$workflow_file" \
"nvidia_nim/nvidia/llama-3.3-nemotron-super-49b-v1.5 openai_direct/gpt-5.6-luna" \
"nvidia_nim/nvidia/llama-3.3-nemotron-super-49b-v1.5 openai-direct/gpt-5.6-luna" \
"nvidia_nim/nvidia/llama-3.3-nemotron-super-49b-v1.5 openai_direct/gpt-5.4" \
"nvidia_nim/nvidia/llama-3.3-nemotron-super-49b-v1.5 openai-direct/gpt-5.4" \
Comment on lines +173 to +174

@devin-ai-integration devin-ai-integration Bot Aug 25, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔍 gpt-5.4 rename still incomplete in pytest contract test

test_strix_nvidia_nim_not_found_fallback.py:195 and :205 still assert gpt-5.6-luna against the live workflow, which commit a724582 already changed to gpt-5.4 (.github/workflows/strix.yml:456, .github/workflows/strix.yml:837). Those assertIn checks fail under pytest tests, so this PR does not fully close the rename it targets.

Open in Devin Review

Was this helpful? React with 👍 or 👎 to provide feedback.

"Strix tries another NVIDIA hosted model before falling back to direct OpenAI"
assert_file_not_contains "$workflow_file" "github_models/openai/o3" "Strix fallback list must not depend on GitHub Models, which is in platform-wide retirement"
assert_file_contains "$workflow_file" "Nvidia_nimException" "Strix workflow recognizes provider-scoped NVIDIA NIM failures"
Expand Down
Loading