Repository navigation
superseded by #1263: make Azure and cross-provider fallbacks executable #1213
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
seonghobae
wants to merge
32
commits into
fix/organization-loop-oidc-fallback
from
fix/strix-baseline-provider-exhaustion
Closed
Changes from 4 commits
Commits
Show all changes
32 commits
Select commit
Hold shift + click to select a range
5dbf903
fix: separate Strix baseline provider exhaustion
d065e69
fix(strix): neutralize empty Caido bootstrap outages
b9dd912
Merge branch 'main' into fix/strix-baseline-provider-exhaustion
6b03822
Merge latest main into Strix provider fallback branch
7179abb
fix(strix): preserve primary-only baseline result
94eafa4
refactor(strix): remove obsolete fallback probe
51a4aa7
fix(strix): fallback on unsupported sampling defaults
b1ab66f
Merge remote-tracking branch 'origin/main' into fix/strix-baseline-pr…
d1a5a1e
Merge remote-tracking branch 'origin/main' into fix/strix-baseline-pr…
8646703
Merge current main into Strix provider exhaustion fix
a3b149b
fix(strix): align manifest finding decisions
97e283e
Merge branch 'main' into fix/strix-baseline-provider-exhaustion
d3246d0
Merge branch 'main' into fix/strix-baseline-provider-exhaustion
60f5150
docs(strix): clarify provider exhaustion exits
3205c3e
merge: reconcile Strix provider failure signals
4452244
Merge remote-tracking branch 'origin/main' into HEAD
8063b7b
Merge branch 'main' into fix/strix-baseline-provider-exhaustion
99ed4ce
Merge branch 'main' into fix/strix-baseline-provider-exhaustion
f915928
Merge branch 'main' into fix/strix-baseline-provider-exhaustion
d006293
Merge remote-tracking branch 'refs/remotes/origin/main' into HEAD
94db1b8
Merge remote-tracking branch 'refs/remotes/origin/fix/organization-lo…
83c2944
Merge parent and repair Azure sampling fallback routing
6f6e507
Merge remote-tracking branch 'origin/fix/organization-loop-oidc-fallb…
a675dac
fix(strix): accept clean fallback model advisory
32543e0
fix(strix): accept clean HF advisory
86408ba
docs(strix): record clean fallback advisories
9dcd1d6
fix(strix): preserve fail-closed warning scan
3868a21
fix(strix): isolate cross-provider OpenAI fallback transport
6493023
Merge remote-tracking branch 'origin/fix/strix-baseline-provider-exha…
5edaf36
fix(strix): bound clean advisory filtering
5ab5834
fix(strix): normalize the fallback model before dispatch, not just cr…
8d0f7ca
fix(strix): ignore exact optional web search advisory
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,41 @@ | ||
| # Strix PR baseline/provider-exhaustion incident | ||
|
|
||
| ## Observed failure | ||
|
|
||
| LineageWeave PR 392 run `32530198775` reported a critical secret in the | ||
| nonexistent `frontend/src/config.ts`. The trusted changed-file mapper correctly | ||
| classified that report as unchanged, but later fallback attempts ended in | ||
| provider HTTP 410 retirement brownouts. The gate retained the earlier severity | ||
| rank and returned the same exit code used for changed-file findings, so the | ||
| outer workflow could not distinguish the cleared baseline report from a real | ||
| pull-request vulnerability. | ||
|
|
||
| A later central PR run reported zero vulnerabilities and then failed before | ||
| scanning when Strix's local Caido process did not accept connections on | ||
| `127.0.0.1:48080`; the outer workflow did not yet recognize that exact scanner | ||
| bootstrap outage as infrastructure. | ||
|
|
||
| ## Root cause and repair | ||
|
|
||
| The quick gate already owns the exact PR-head changed-file mapping decision. | ||
| After it has classified every report as `allow_baseline`, a later provider | ||
| exhaustion now returns the dedicated status 3. The trusted reusable workflow | ||
| maps only that status to a neutral infrastructure warning. Changed, unmapped, | ||
| or manifest findings still return the blocking status, and configuration or | ||
| unexpected statuses still fail closed. | ||
|
|
||
| The outer workflow also recognizes only the observed `loginAsGuest` retry | ||
| exhaustion with curl exit 7 against Strix's fixed local Caido port. It is neutral | ||
| only when no positive vulnerability or severity signal exists; every other | ||
| runtime failure remains blocking. | ||
|
|
||
| ## Verification | ||
|
|
||
| - A three-attempt regression reproduces an unchanged critical report followed | ||
| by two provider failures and requires status 3. | ||
| - Existing source tests require changed findings to remain blocking and clean | ||
| unchanged findings to remain admissible. | ||
| - A workflow regression requires the exact Caido bootstrap outage to be neutral | ||
| with zero findings and blocking when any vulnerability is reported. | ||
| - The central Python suite, native workflow validation, Bash syntax checks, and | ||
| the complete Strix shell regression suite run on the final tree. |
|
seonghobae marked this conversation as resolved.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.