add Evacuate Server (evacuate Action) #931
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ex)
ServerPassword password =
os.compute().servers().evacuate("1427b0a6-e6a1-496",
EvacuateOptions.create().host("compute1").onSharedStorage(false));
System.out.println(password.getPassword());
|
Hi @taemin77, Could you also add a test to the PR? Maybe just a short unit test. Please take a look at the other tests in the |
test-1pro
commented
Feb 10, 2017
|
All checks have failed? |
|
Hi @taemin77, |
auhlig
reviewed
Feb 13, 2017
| @@ -67,7 +68,7 @@ protected Service service() { | |||
|
|
|||
| @Test | |||
| public void evacuateServer() throws Exception { | |||
| respondWith(JSON_SERVER_CREATE); | |||
| respondWith(JSON_SERVER_EVACUATE); | |||
|
|
|||
| ServerPassword password = osv3().compute().servers().evacuate("e565cbdb-8e74-4044-ba6e-0155500b2c46", EvacuateOptions.create().host("server-test-1").onSharedStorage(false)); | |||
| assertNotNull(password.getPassword()); | |||
There was a problem hiding this comment.
One last thing: Instead of assertNotNull(..)maybe assertEquals(password.getPassword(), "MySecretPass")
|
Besides the comment above this looks good @taemin77 👍 |
|
Very cool. Many thanks for your woke @taemin77! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, I'm taemin
I added Evacuate Server.
I did tests about this api and checked the result.
The example below.
ServerPassword password =
os.compute().servers().evacuate("1427b0a6-e6a1-496",
EvacuateOptions.create().host("compute1").onSharedStorage(false));
System.out.println(password.getPassword());
I hope you review codes I pulled.