App catalog/Murano API support #836
Conversation
nmakhotkin
commented
Sep 27, 2016
nmakhotkin
commented
- Added Murano Service support to OSClient;
- Added Murano Service to list of available APIs;
- Implemented murano envronment API;
- Added unit-tests for murano environments.
* Added Murano Service support to OSClient; * Added Murano Service to list of available APIs; * Implemented murano envronment API; * Added unit-tests for murano environments.
|
It partially fixes #830 |
* Included unit-tests
* Implemented actions:
- configure
- get
- deploy
- delete
|
Do you want to continue working on this PR, @nmakhotkin ? |
|
definitely yes, I plan to create a couple commits more. |
|
I'm not sure if I do it correct. Is this acceptable if I send more than one commit in one pull request? If not, could you please explain the usual workflow for sending more than 1 commit in a chain? Each next one depends on previous one. |
|
Either way is absolutely fine. |
nmakhotkin
changed the title
|
Ok, thanks for the clarification. I just added [WIP] to the title of the PR. |
* Added services() like it is done in python-muranoclient * Implemented application list,get,create,update,delete * Added corresponding unit-tests for this functionality
|
Hi, @auhlig @vinodborole ! I just finished implementing basic Murano API functional. With this changes, user will be able to:
Note: I also tested all this functionality on our development OpenStack lab and it works fine. PR is ready for review now. P.S. The next plan is to improve existing murano API functionality: deployments API, packages API, categories API. These changes can be independent from each other and will contain only one commit in PR. |
* Since stable/mitaka Murano service type is 'application-catalog' instead of 'application_catalog'
* Forgot to fix in tests
nmakhotkin
changed the title
|
@nmakhotkin and team! Great work! Quick pass I don't see anything that sticks out. Thanks for adding all the tests to back your work. LGTM. @auhlig and @vinodborole i'll let you guys complete the review and merge if things look good. I was recently in correspondence with this team (Mirantis) about adding this support to OpenStack4j in incremental stages so wanted to comment :) |
|
Thanks for sharing the info Jeremy. |
|
Thanks guys! |
