Add Neutron agent-list #807
Conversation
Neutron agent-list function was supported. Fixed a missing symbol bug from Trove merge This change is contributed by Yin Zhang, Magnus Broman, Qin An (@biogerm)
|
@gondor @vinodborole @auhlig Here is the new PR. The old one was abandoned. Please take a look. Thank you! |
| * @param str - string to be parsed | ||
| * @return Date | ||
| */ | ||
| private Date parseDate(String str) { |
There was a problem hiding this comment.
Just an idea: Could use https://github.com/ContainX/openstack4j/blob/master/core/src/main/java/org/openstack4j/openstack/internal/Parser.java instead of doing it here.
Makes sense?
There was a problem hiding this comment.
Sounds like a good idea. I am now working on next PR so I will make a note and include it later.
|
Waiting for this to be merged because this commit fixes compiling issue. @gondor @vinodborole |
|
@biogerm Could you address the comment and resolve the conflict? |
Neutron agent-list function was supported. Fixed a missing symbol bug from Trove merge This change is contributed by Yin Zhang, Magnus Broman, Qin An (@biogerm)
|
@auhlig Ah. I was thinking to update source code in the next PR but since there's conflicts again... ok I will push a new PR for this. |
|
@auhlig I looked into this and here is what I found out about. Neutron Agent has a different time stamp format. It's different than other API calls say, image-list. So that's why there's a different parser just for Agent list. Should I move this parser to Parser class or just keep it here? What do you say? |
|
One place for that kind of methods might be better than multiple in order to avoid unnecessary code duplication. So I would move it to the Parser class. Do you agree? |
|
I'm thinking the same. Here's the new commit. |
Conflicts: core-test/src/main/java/org/openstack4j/api/network/NetworkTests.java core/src/main/java/org/openstack4j/openstack/networking/domain/NeutronAgent.java core/src/main/java/org/openstack4j/openstack/provider/DefaultAPIProvider.java
|
Cool. Thanks for all that work @biogerm |
|
Hey @biogerm, |
# Conflicts: # core/src/main/java/org/openstack4j/api/Builders.java # core/src/main/java/org/openstack4j/openstack/provider/DefaultAPIProvider.java
|
@auhlig no problem. it's quick :) |
|
Thanks. Merging now |
Neutron agent-list function was supported.
Fixed a missing symbol bug from Trove merge
This change is contributed by Yin Zhang, Magnus Broman, Qin An
(@biogerm)