-
Notifications
You must be signed in to change notification settings - Fork 366
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow value to be object type in ServiceConfig #1061
Conversation
@ekasitk can you please share the use case for this change request? |
When setting service parameters, values can be string or number.
This PR permits ServiceConfig.set() to accept number and generate the json like: Otherwise, all values will always be treated as string, i.e. "dfs.replication" : "1", which is not complied well to the API. Ref: https://developer.openstack.org/api-ref/data-processing/?expanded=show-details-of-a-cluster-detail. |
Makes sense. Or not @vinodborole? |
@vinodborole @auhlig |
@ekasitk sure not a problem |
@vinodborole @auhlig |
LGTM @auhlig what do you think? |
LGTM. Many thanks @ekasitk |
This PR allows values in ServiceConfig to be an integer or any other types than just a string. So the generated JSON is correctly formatted according to the type of value.