Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support automatically reload when config file changes #712

Open
J1a-wei opened this issue Feb 10, 2023 · 2 comments
Open

Support automatically reload when config file changes #712

J1a-wei opened this issue Feb 10, 2023 · 2 comments
Labels
TeamCerberus Under active development by TeamCerberus @Consensys

Comments

@J1a-wei
Copy link

J1a-wei commented Feb 10, 2023

We are developing a eth staking infrastructure, using web3signer for signatures, and it looks great. It has been running stable for six months in mainnet. There is a small feature that we hope to implement, since our environment is in k8s. When we have a new user staking eth, we will modify the configmap and the final application time to the container is uncertain. We have to poll to call the interface that queries the load key and call /reload manually. So is it possible to listen to the configuration file via fsnotify(I am not a Java expert, this is a Go -based open source library) or some technique that allows web3signer to automatically reload when changes occur?

Relevant issue: #689
Kubernetes: https://kubernetes.io/docs/reference/config-api/kubelet-config.v1beta1/
configMapAndSecretChangeDetectionStrategy

@jframe jframe added the TeamCerberus Under active development by TeamCerberus @Consensys label Feb 13, 2023
@iamhsk
Copy link

iamhsk commented Feb 14, 2023

Thank you for opening this issue. We are currently working on Shanghai/Capella upgrade, so after those upgrades we'll prioritize this issue accordingly. But in the meantime if you had other feedback on web3signer, please feel free to reach out on Discord or GitHub.

@iamhsk
Copy link

iamhsk commented Feb 14, 2023

Related to #512

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
TeamCerberus Under active development by TeamCerberus @Consensys
Projects
None yet
Development

No branches or pull requests

3 participants