Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(typescript): correct type for IDistributeRawTransaction.privateFor #54

Closed
petermetz opened this issue Aug 31, 2023 · 0 comments · Fixed by #57
Closed

fix(typescript): correct type for IDistributeRawTransaction.privateFor #54

petermetz opened this issue Aug 31, 2023 · 0 comments · Fixed by #57

Comments

@petermetz
Copy link
Contributor

readonly privateFor: string;

  export interface IDistributeRawTransaction {
    readonly privateKey: string;
    readonly privateFrom: string;
    readonly privateFor: string;
    readonly privacyGroupId: string;
    readonly nonce: string;
    readonly to: string;
    readonly data: string;
  }

Shouldn't this privateFor be an array of keys rather than a single string? If you can confirm that this is the case, then I can send a PR fixing it.

Same question about this interface:

  export interface IPtmSend extends IOptions {
    readonly privateFor: string;
  }

https://github.com/Consensys/web3js-quorum/blob/eff69e832c6ac1528899d8f969641ff203fa1c4d/src/typescript/index.d.ts#L82C1-L84C4

petermetz added a commit to petermetz/web3js-quorum that referenced this issue Aug 31, 2023
Also fixes it for the `IPtmSend` interface in addition to `IDistributeRawTransaction`

Fixes Consensys#54

Signed-off-by: Peter Somogyvari <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant