Bugfix/whitelist filter #992
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…aviour before 0.10. Log message to recommend users to switch on remote key validation for better security
# Conflicts: # cli/config-cli/src/test/java/com/quorum/tessera/config/cli/OverrideUtilTest.java # config/src/main/java/com/quorum/tessera/config/ServerConfig.java # tessera-jaxrs/jaxrs-client/src/main/java/com/quorum/tessera/jaxrs/client/ClientFactory.java # tessera-jaxrs/jaxrs-client/src/test/java/com/quorum/tessera/jaxrs/client/ClientFactoryTest.java # tessera-partyinfo/src/main/resources/tessera-partyinfo-spring.xml
# Conflicts: # tessera-jaxrs/sync-jaxrs/src/main/java/com/quorum/tessera/p2p/RestP2pClient.java # tessera-jaxrs/sync-jaxrs/src/main/java/com/quorum/tessera/p2p/RestResendClient.java # tessera-jaxrs/sync-jaxrs/src/main/java/com/quorum/tessera/p2p/RestResendClientFactory.java # tessera-partyinfo/src/main/java/com/quorum/tessera/sync/ResendClient.java
…r connections from quorum to tessera
Add localhost ip to whitelist
namtruong
requested review from
chris-j-h,
melowe and
nicolae-leonte-go
as code owners
Krish1979
previously approved these changes
Feb 7, 2020
Krish1979
previously approved these changes
Feb 7, 2020
Codecov Report
@@ Coverage Diff @@
## master #992 +/- ##
=========================================
Coverage ? 99.31%
Complexity ? 2235
=========================================
Files ? 337
Lines ? 6106
Branches ? 364
=========================================
Hits ? 6064
Misses ? 5
Partials ? 37
Continue to review full report at Codecov.
|
Krish1979
approved these changes
Feb 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove use of whitelist filter on Q2TRestApp endpoints as the restrictions on requests from Quorum should not be based on peers' URLs.
Add local IPs to list of whitelisted to prevent issues when running upcheck from local nodes. Also fix whitelist acceptance tests