Separate P2P and Resend clients #982
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…aviour before 0.10. Log message to recommend users to switch on remote key validation for better security
# Conflicts: # cli/config-cli/src/test/java/com/quorum/tessera/config/cli/OverrideUtilTest.java # config/src/main/java/com/quorum/tessera/config/ServerConfig.java # tessera-jaxrs/jaxrs-client/src/main/java/com/quorum/tessera/jaxrs/client/ClientFactory.java # tessera-jaxrs/jaxrs-client/src/test/java/com/quorum/tessera/jaxrs/client/ClientFactoryTest.java # tessera-partyinfo/src/main/resources/tessera-partyinfo-spring.xml
…://github.com/jpmorganchase/tessera into separate-p2p-and-resend-client
Adds a new property called "resendWaitTime" to the P2P server configuration. This property denotes, in milliseconds, the timeout period for reading a response when calling the "/resend" API endpoint. By default, a 2 hour period was chosen as long enough for a medium sized database (about 500k transactions).
…o separate-p2p-and-resend-client
prd-fox
requested review from
chris-j-h,
melowe,
namtruong and
nicolae-leonte-go
as code owners
Codecov Report
@@ Coverage Diff @@
## master #982 +/- ##
=========================================
Coverage ? 99.32%
Complexity ? 2221
=========================================
Files ? 336
Lines ? 6069
Branches ? 363
=========================================
Hits ? 6028
Misses ? 5
Partials ? 36Continue to review full report at Codecov.
|
nicolae-leonte-go
approved these changes
Jan 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The "/resend" call can potentially take a long time to call, dependant upon the number of transactions that need to be resent. The default timeout for all clients was small, to cater for calling the PartyInfo API, but this means that resend requests often fail and get called repeatedly.
This causes nodes to resend the same transaction multiple times, which is bad for everybody.
This PR splits the clients up, and gives the Resend client a much larger timeout. If an even longer timeout is required, then it can be configured in the P2P server properties, the same as other polling periods are right now.