Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable some previously disabled longer running tests #974

Merged
merged 4 commits into from
Jan 20, 2020

Conversation

chris-j-h
Copy link
Collaborator

  • A few longer running tests were not included in our maven builds (all **IT.java tests are currently ignored in the gradle builds).
    No test is long enough to warrant not being included.
  • Remove CoreIT test
  • Un-exclude javax.inject dependencies from jersey-server pom. These were originally added due to collisions with grpc dependencies that have since been removed.

* jnacl and kalium (only run when corresponding profile is active)
* jnacl encrypt and decrypt
@chris-j-h chris-j-h added enhancement Non-user code enhancements testing labels Jan 15, 2020
@chris-j-h chris-j-h changed the title Enable longer running tests Enable some previously disabled longer running tests Jan 15, 2020
@codecov-io
Copy link

codecov-io commented Jan 15, 2020

Codecov Report

Merging #974 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #974      +/-   ##
============================================
+ Coverage      99.3%   99.31%   +<.01%     
- Complexity     2173     2181       +8     
============================================
  Files           328      329       +1     
  Lines          5922     5951      +29     
  Branches        354      355       +1     
============================================
+ Hits           5881     5910      +29     
  Misses            5        5              
  Partials         36       36
Impacted Files Coverage Δ Complexity Δ
...n/java/com/quorum/tessera/config/ServerConfig.java 100% <100%> (ø) 26 <3> (+1) ⬆️
...um/tessera/config/util/IntervalPropertyHelper.java 100% <100%> (ø) 5 <5> (?)
...com/quorum/tessera/jaxrs/client/ClientFactory.java 100% <100%> (ø) 8 <3> (ø) ⬇️
...va/com/quorum/tessera/admin/ConfigServiceImpl.java 100% <100%> (ø) 10 <3> (+2) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9124984...839606f. Read the comment docs.

@melowe melowe merged commit 8dea70b into master Jan 20, 2020
@chris-j-h chris-j-h deleted the enable-integration-tests branch January 21, 2020 14:15
@Krish1979 Krish1979 added the 0.10.3 0.10.3 label Feb 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0.10.3 0.10.3 enhancement Non-user code enhancements testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants