Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CLI overrides of encryptor config and map fields #962

Merged
merged 2 commits into from
Jan 10, 2020

Conversation

chris-j-h
Copy link
Collaborator

Resolves #961

  • Fixes a bug that meant no fields in the EncryptorConfig could be overriden.
  • Updates OverrideUtil to also support Maps meaning the keyVaultConfig.properties and encryptor.properties fields can now be overriden with the CLI

@codecov-io
Copy link

codecov-io commented Jan 10, 2020

Codecov Report

Merging #962 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##             master    #962      +/-   ##
===========================================
+ Coverage      99.3%   99.3%   +<.01%     
- Complexity     2146    2150       +4     
===========================================
  Files           328     328              
  Lines          5871    5875       +4     
  Branches        345     347       +2     
===========================================
+ Hits           5830    5834       +4     
  Misses            5       5              
  Partials         36      36
Impacted Files Coverage Δ Complexity Δ
...a/com/quorum/tessera/config/JaxbConfigFactory.java 100% <100%> (ø) 5 <2> (+1) ⬆️
...va/com/quorum/tessera/config/cli/OverrideUtil.java 100% <100%> (ø) 61 <3> (+3) ⬆️
...ra/cli/keypassresolver/CliKeyPasswordResolver.java 97.82% <0%> (-0.05%) 20% <0%> (ø)
...uorum/tessera/data/migration/JdbcDataExporter.java 100% <0%> (ø) 4% <0%> (ø) ⬇️
...rum/tessera/data/migration/SqliteDataExporter.java 100% <0%> (ø) 4% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 59c421a...41da9ea. Read the comment docs.

@melowe melowe merged commit bb5fc0d into master Jan 10, 2020
@chris-j-h chris-j-h deleted the fix-encryptor-overrides branch January 13, 2020 12:34
@Krish1979 Krish1979 added the 0.10.3 0.10.3 label Feb 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0.10.3 0.10.3 bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add CLI override support for encryptorConfig and keyVaultConfig
5 participants