Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Async partyinfo request #953

Merged
merged 7 commits into from
Jan 7, 2020
Merged

Async partyinfo request #953

merged 7 commits into from
Jan 7, 2020

Conversation

namtruong
Copy link
Collaborator

Make partyinfo requests asynchronous so the next request does not have to wait for the previous one.

Fix #949

melowe
melowe previously approved these changes Jan 2, 2020
@namtruong namtruong closed this Jan 3, 2020
@namtruong namtruong reopened this Jan 6, 2020
@codecov-io
Copy link

codecov-io commented Jan 6, 2020

Codecov Report

Merging #953 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #953      +/-   ##
============================================
+ Coverage     99.31%   99.31%   +<.01%     
- Complexity     2087     2088       +1     
============================================
  Files           320      320              
  Lines          5708     5709       +1     
  Branches        328      328              
============================================
+ Hits           5669     5670       +1     
  Misses            5        5              
  Partials         34       34
Impacted Files Coverage Δ Complexity Δ
.../com/quorum/tessera/partyinfo/PartyInfoPoller.java 100% <100%> (ø) 9 <4> (+1) ⬆️
...a/config/cli/admin/subcommands/AddPeerCommand.java 97.36% <0%> (ø) 11% <0%> (ø) ⬇️
.../quorum/tessera/sync/SyncResponseMessageCodec.java 96.77% <0%> (ø) 5% <0%> (ø) ⬇️
...ain/java/com/quorum/tessera/p2p/RestP2pClient.java 93.1% <0%> (ø) 9% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f6f5b60...9c4a152. Read the comment docs.

@melowe melowe merged commit 54e13ee into master Jan 7, 2020
@namtruong namtruong deleted the async-partyinfo-request branch January 17, 2020 15:46
@Krish1979 Krish1979 added 0.10.3 0.10.3 enhancement Non-user code enhancements labels Feb 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0.10.3 0.10.3 enhancement Non-user code enhancements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Parallelise 'partyinfo' request
5 participants