-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding support for AWS Secrets Manager #947
Conversation
…eature/AWSSecretManager
…eature/AWSSecretManager
…gerDone AWS Secrets Manager implementation for KeyVault added
…o feature/AWSSecretManager � Conflicts: � cli/cli-api/src/test/java/com/quorum/tessera/cli/keypassresolver/CliKeyPasswordResolverTest.java � cli/config-cli/src/main/java/com/quorum/tessera/config/cli/parsers/KeyGenerationParser.java � cli/config-cli/src/test/java/com/quorum/tessera/config/cli/OverrideUtilTest.java � cli/config-cli/src/test/java/com/quorum/tessera/config/cli/parsers/KeyGenerationParserTest.java � config-migration/src/test/java/com/quorum/tessera/config/migration/test/FixtureUtil.java � config/src/main/java/com/quorum/tessera/config/JaxbConfigFactory.java � config/src/main/java/com/quorum/tessera/config/KeyConfiguration.java � config/src/main/java/com/quorum/tessera/config/adapters/KeyDataAdapter.java � config/src/test/java/com/quorum/tessera/config/adapters/KeyDataAdapterTest.java � key-generation/src/main/java/com/quorum/tessera/key/generation/DefaultKeyGeneratorFactory.java � key-generation/src/test/java/com/quorum/tessera/key/generation/KeyGeneratorFactoryTest.java
…Pair.java Co-Authored-By: chris-j-h <[email protected]>
…Pair.java Co-Authored-By: chris-j-h <[email protected]>
…hub.com/vgeorgescu/tessera into feature/AWSSecretManager � Conflicts: � tessera-grpc/grpc-service/pom.xml
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
I've made some changes to the key vault config to facilitate the addition of new implementations by having simple properties associated with the value impl. I'll try and the changes required for AWS support following this. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Resolving the merge conflicts and making the necessary changes to work with our updated master branch have been made and raised as a separate PR. Thanks for making this change, this PR will be closed in favour of #955. |
# Conflicts: # cli/config-cli/src/main/java/com/quorum/tessera/config/cli/KeyGenCommand.java # cli/config-cli/src/test/java/com/quorum/tessera/config/cli/KeyGenCommandTest.java # config/src/main/java/com/quorum/tessera/config/DefaultKeyVaultConfig.java # config/src/main/java/com/quorum/tessera/config/KeyConfiguration.java # config/src/main/java/com/quorum/tessera/config/KeyVaultConfigConverter.java # config/src/main/java/com/quorum/tessera/config/constraints/KeyVaultConfigValidator.java # config/src/main/java/com/quorum/tessera/config/constraints/ValidKeyVaultConfig.java # config/src/test/java/com/quorum/tessera/config/KeyConfigurationTest.java # config/src/test/java/com/quorum/tessera/config/KeyVaultConfigConverterTest.java # config/src/test/java/com/quorum/tessera/config/constraints/KeyVaultConfigValidatorTest.java # pom.xml
Codecov Report
@@ Coverage Diff @@
## master #947 +/- ##
===========================================
- Coverage 99.31% 99.3% -0.02%
- Complexity 2088 2146 +58
===========================================
Files 320 328 +8
Lines 5709 5871 +162
Branches 328 345 +17
===========================================
+ Hits 5670 5830 +160
Misses 5 5
- Partials 34 36 +2
Continue to review full report at Codecov.
|
Quorum documentation PR - Consensys/quorum#919