Use picocli for main cli #946
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Create a PicoCli cmd with usage and help, and dynamically produce CLI options from config object fields
Add keygen as a subcommand to the main tessera command
Add keygen as a subcommand to the main tessera command
Add keyupdate as a subcommand to the main tessera command
… and apply CLI overrides
# Conflicts: # pom.xml
This is a temporary stopgap until the cli module is flattened and further simplified
# Conflicts: # tessera-dist/tessera-launcher/build.gradle
Make minor changes to the pico implementation code in response to test migration
e.g. --override root.branch[1].property=overridden-value. Previously, this was not possible.
Update todos
…nges). Ignore coverage for parsers and other code that's due for removal.
melowe
requested review from
chris-j-h,
namtruong,
nicolae-leonte-go,
prd-fox and
SatpalSandhu61
as code owners
Codecov Report
@@ Coverage Diff @@
## master #946 +/- ##
============================================
- Coverage 99.32% 99.28% -0.04%
+ Complexity 2078 2050 -28
============================================
Files 311 316 +5
Lines 5778 5622 -156
Branches 326 318 -8
============================================
- Hits 5739 5582 -157
Misses 5 5
- Partials 34 35 +1
Continue to review full report at Codecov.
|
Ignore unmatchable items, log refelct exception at debug level and move on to next.
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Krish1979
approved these changes
Dec 30, 2019
This was referenced May 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Complete outstanding port from commons-cli to piccolo.
Collapse admin-cli into config cli.